ncm-network: fix nmstate package definition in Kickstart config #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aka7
approved these changes
Sep 13, 2023
jrha
reviewed
Sep 13, 2023
| @@ -13,4 +13,4 @@ prefix "/software/components/network"; | |||
| prefix '/software/packages'; | |||
| 'nmstate' = dict(); | |||
| prefix "/system/aii/osinstall/ks"; | |||
| "NetworkManager-config-server" = dict(); | |||
| 'packages' = append("NetworkManager-config-server"); | |||
There was a problem hiding this comment.
Probably unnecessary, but for extra safety:
Suggested change
| 'packages' = append("NetworkManager-config-server"); | |
| 'packages' ?= list(); | |
| 'packages' = append(SELF, 'NetworkManager-config-server'); | |
There was a problem hiding this comment.
that should not be needed at all ever. single argument append does it all.
There was a problem hiding this comment.
True, but the explicit SELF guards against users adding more items to the append.
Anyway, it's perfectly fine and now merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1629