Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncm-network: fix nmstate package definition in Kickstart config #1630

Merged
merged 1 commit into from
Sep 13, 2023
Merged

ncm-network: fix nmstate package definition in Kickstart config #1630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ncm-network/src/main/pan/components/network/config-nmstate.pan
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ prefix "/software/components/network";
prefix '/software/packages';
'nmstate' = dict();
prefix "/system/aii/osinstall/ks";
"NetworkManager-config-server" = dict();
'packages' = append("NetworkManager-config-server");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably unnecessary, but for extra safety:

Suggested change
'packages' = append("NetworkManager-config-server");
'packages' ?= list();
'packages' = append(SELF, 'NetworkManager-config-server');

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that should not be needed at all ever. single argument append does it all.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, but the explicit SELF guards against users adding more items to the append.
Anyway, it's perfectly fine and now merged.