Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't override the default selection colours #2479

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Conversation

hadley
Copy link
Member

@hadley hadley commented Apr 22, 2024

Fixes #2139

@maelle Any concerns with this? I don't remember why I did it, and the linked issue suggests it's a minor accessibility issue.

@hadley hadley requested a review from maelle April 22, 2024 13:18
Copy link
Collaborator

@maelle maelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no concern 🙂

NEWS.md Outdated Show resolved Hide resolved
@hadley hadley merged commit 62e9945 into main Apr 23, 2024
12 checks passed
@hadley hadley deleted the no-selection-override branch April 23, 2024 13:06
SebKrantz pushed a commit to SebKrantz/pkgdown that referenced this pull request Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlighted text styles can make text unreadable in rare cases
2 participants