Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't override the default selection colours #2479

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Don't override the default selection colours #2479

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5201b18
Don't override the default selection colours
hadley Apr 22, 2024
1c2348a
Update NEWS.md
hadley Apr 23, 2024
b0e3e41
Merge branch 'main' into no-selection-override
hadley Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# pkgdown (development version)

* pkgdown no longer overrides the default selection colours. This improves
accessibility for users who have set their own colours in their browser
settings (#2139).
hadley marked this conversation as resolved.
Show resolved Hide resolved
* `build_article()` no longer generates the wrong source link when you build your site outside of the root directory (#2172).
* `build_reference()` matches usage for S3 and S4 methods to the style used by R 4.0.0 and later (#2187).
* `<source>` tags now have their `srcref` attributes tweaked in the same way that the `src` attributes of `<img>` tags are (#2402).
Expand Down
4 changes: 0 additions & 4 deletions inst/BS5/assets/pkgdown.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,10 +207,6 @@ body > .container .row {

/* General typography ======================================================= */

::selection {
background-color: mix($primary, $body-bg, 20%);
}

// Ensure in-page images don't run outside their container
main img {
max-width: 100%;
Expand Down
Loading