Strip trailing whitespace throughout R/ + tests/testthat #2566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivroy
changed the title
SebKrantz
pushed a commit
to SebKrantz/pkgdown
that referenced
this pull request
Jun 1, 2024
* Remove trailing WS. * Use usethis syntax (+ separate pkgdown.R and pkgdown-package.R in 2 files) * Delete outdated file * Test lint! (expect_match + expect_null)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #2562 (comment)
Since I had to open all files one by one to do this, I made some quick fixes here and there.
Whitespace disrepencies probably caused by Global option for Strip trailing horizontal whitespace when saving is ignored rstudio/rstudio#9902. This setting is useful to have when you are on your own projects, but can be disruptive while working on someone else's project.
How I did this
I have the global setting in RStudio to trim whitespace and force files to end with a new line.
Then, I had to do a temp modification (like adding a dot at the end of a comment), then save, then undo my modification. (RStudio will not save if it doesn't detect a change in contents first).
I did this on mac. So, hopefully not too many ghost instance of git change on your side. (r-lib/testthat#1958)