Don't call init_site() when lazy = TRUE + use posix line end + document init_site() + speed cli console output
#2642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rame)` in `section_init()`
…call it anyway if necessary.
hadley
approved these changes
Jun 6, 2024
R/init.R
Outdated
| @@ -21,6 +29,7 @@ | |||
| #' @inheritParams build_articles | |||
| #' @export | |||
| init_site <- function(pkg = ".") { | |||
| local_options_console() | |||
There was a problem hiding this comment.
Are you sure we shouldn't just callsection_init() here? I also noticed that init_site() lacks override, and I needed it when I started experimenting with quarto.
That would make it more consistent with the other functions
There was a problem hiding this comment.
Now clear that it shouldn't be called here 😄
There was a problem hiding this comment.
Hi Hadley, actually, cache_cli_colours() should be used in init_site(),
bench marks
# without caching
expression min median `itr/sec` mem_alloc `gc/sec` n_itr n_gc total_time result
<bch:expr> <bch> <bch:> <dbl> <bch:byt> <dbl> <int> <dbl> <bch:tm> <list>
1 init_site() 3.23s 3.23s 0.309 14.7MB 0.619 1 2 3.23s <NULL>
# with caching
expression min median `itr/sec` mem_alloc `gc/sec` n_itr n_gc total_time result
<bch:expr> <bch> <bch:> <dbl> <bch:byt> <dbl> <int> <dbl> <bch:tm> <list>
1 init_site() 3.02s 3.02s 0.331 8.89MB 0.992 1 3 3.02s <NULL>Significant difference in memory usage. And also, the output prints much faster in the console!
Co-authored-by: Hadley Wickham <[email protected]>
This was referenced Jun 6, 2024
Merge commit '8defd983aab0cf0eb9517813ecb4102915c84008' #Conflicts: # R/init.R
olivroy
commented
Jun 7, 2024
hadley
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not talking about
init_site()anymore after this!Follow-up to #2571
Only call
init_site()iflazy = FALSEDocument where
init_site()is actually needed. #2557 (comment)To speed console printing, create
cache_cli_colours(). (bench marks in #2557 (comment)) Tip taken from r-lib/cli#607I put in the Posix line end thing as a follow-up to r-lib/testthat#1958 (comment)
I am no longer seeing spurious diff in snapshot tests this way.
Still haven't figure out no-pandoc test failure! Will take a look again after #2645. This appears to be stochastic (just encountered it on main)