Public upkeep checklist #1825
Public upkeep checklist #1825
Conversation
- add 'tidy' arg to make_upkeep_issue() - add generic checklist and some helpers for conditial creation of todos
Co-authored-by: Jennifer (Jenny) Bryan <[email protected]>
I was thinking of just doing |
|
As long as you give the file(name) issue some thought, I'm OK with what you choose. Let's just make sure we aren't introducing some new convention. Do what seems most consistent with what we've done for other functions with generic and tidy versions. (This could happen for |
- use local_mocked_bindings for git branch names - use local_edition for testthat edition
Default to current year
Co-authored-by: Jennifer (Jenny) Bryan <[email protected]>
…ethis into public-upkeep-checklist
* for `use_tidy_upkeep_issue()`, if `year` is specified it will be used in the title and used to select the subset of checklist items included (as before). If `year` is `NULL`, the current year will be in the issue title, but all current and previous checklists will be included. * for `use_upkeep_issue()` `year` is only used in the title, as there are not multiple year-based checklists.
|
I think this is almost done now @jennybc. An example of a non-tidy issue: https://github.com/ateucher/rmapshaper/issues/149 |
Co-authored-by: Jennifer (Jenny) Bryan <[email protected]>
Co-authored-by: Hadley Wickham <[email protected]>
This adds a public function
use_upkeep_issue()similar touse_tidy_upkeep_issue()for general (i.e. non-tidyverse) use.I factored out the internals of
use_tidy_upkeep_issue()intomake_upkeep_issue()which is called by both exported functions.I created a default checklist for
use_upkeep_issue()with some good practices... I would love some feedback on what should be included there. Many of them are one-time only fixes, but most are conditionally populated so should only show up when needed.I did also add the ability to add custom upkeep tasks similar to
use_release_checklist().Closes #1794.