Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public upkeep checklist #1825

Merged
merged 45 commits into from
Apr 26, 2023
Merged

Public upkeep checklist #1825

merged 45 commits into from
Apr 26, 2023

Commits on Apr 12, 2023

  1. Factor out internals of use_tidy_upkeep_issue

    @ateucher
    ateucher committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    7bea941 View commit details
    Browse the repository at this point in the history

  2. add generic use_upkeep_issue: 

    - add 'tidy' arg to make_upkeep_issue()
- add generic checklist and some helpers for
conditial creation of todos
    @ateucher
    ateucher committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    dc19cb2 View commit details
    Browse the repository at this point in the history

  3. Add test for use_upkeep_issue, update snapshots

    @ateucher
    ateucher committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    fc7b17d View commit details
    Browse the repository at this point in the history

  4. document

    @ateucher
    ateucher committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    df48068 View commit details
    Browse the repository at this point in the history

  5. negate uses_testthat_edition

    @ateucher
    ateucher committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    e125868 View commit details
    Browse the repository at this point in the history

  6. Update documentation for use_upkeep_issue()

    @ateucher
    ateucher committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    60a0d0d View commit details
    Browse the repository at this point in the history

  7. Add some todos to use_upkeep_checklist; update snap

    @ateucher
    ateucher committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    5d77e59 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2023

  1. styling

    @ateucher
    ateucher committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    e203878 View commit details
    Browse the repository at this point in the history

  2. Conditionally add lifecycle to upkeep checklist

    @ateucher
    ateucher committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    80c40c4 View commit details
    Browse the repository at this point in the history

  3. Tests for upkeep_checklist

    @ateucher
    ateucher committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    73cd6ce View commit details
    Browse the repository at this point in the history

  4. skip upkeep_checklist test if no git user

    @ateucher
    ateucher committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    9d90128 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. Add ability to include custom upkeep bullets

    @ateucher
    ateucher committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    795582a View commit details
    Browse the repository at this point in the history

  2. Better title for use_upkeep_checklist() 

    Co-authored-by: Jennifer (Jenny) Bryan <[email protected]>
    @ateucher @jennybc
    ateucher and jennybc authored Apr 17, 2023
    Configuration menu
    Copy the full SHA
    b7f2b4f View commit details
    Browse the repository at this point in the history

  3. Styling and bullet formatting; document

    @ateucher
    ateucher committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    8d5b8a5 View commit details
    Browse the repository at this point in the history

  4. Remove url_check() from upkeep checklist, add backticks

    @ateucher
    ateucher committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    b19c92b View commit details
    Browse the repository at this point in the history

  5. tidy up tests - use local_mocked_bindings, use_package

    @ateucher
    ateucher committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    0027bbf View commit details
    Browse the repository at this point in the history

  6. Update snapshots

    @ateucher
    ateucher committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    0691422 View commit details
    Browse the repository at this point in the history

  7. Separate todos for using tessthat vs upgrading

    @ateucher
    ateucher committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    fcc9ffd View commit details
    Browse the repository at this point in the history

  8. Tests for upkeep 

    - use local_mocked_bindings for git branch names
- use local_edition for testthat edition
    @ateucher
    ateucher committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    6992786 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. Remove year from use_upkeep_issue body, only in title. 

    Default to current year
    @ateucher
    ateucher committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    886ff94 View commit details
    Browse the repository at this point in the history

  2. Remove superfluous empty line

    @ateucher
    ateucher committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    45439a4 View commit details
    Browse the repository at this point in the history

  3. Rename tidy-upkeep to upkeep

    @ateucher
    ateucher committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    d65a053 View commit details
    Browse the repository at this point in the history

  4. Reorganize upkeep.R similar to github-actions. 

    R
    @ateucher
    ateucher committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    6c82f2a View commit details
    Browse the repository at this point in the history

  5. use proj_path to find the README 

    Co-authored-by: Jennifer (Jenny) Bryan <[email protected]>
    @ateucher @jennybc
    ateucher and jennybc authored Apr 18, 2023
    Configuration menu
    Copy the full SHA
    3be191b View commit details
    Browse the repository at this point in the history

  6. Add NEWS item for use_upkeep_issue

    @ateucher
    ateucher committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    0f2c061 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'public-upkeep-checklist' of https://github.com/r-lib/us… 

    …ethis into public-upkeep-checklist
    @ateucher
    ateucher committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    35c4b9c View commit details
    Browse the repository at this point in the history

  8. year always appears in upkeep issue title, defaults to current year. 

    * for `use_tidy_upkeep_issue()`, if `year` is specified it will be used in the title and used to select the subset of checklist items included (as before). If `year` is `NULL`, the current year will be in the issue title, but all current and previous checklists will be included.
* for `use_upkeep_issue()` `year` is only used in the title, as there are not multiple year-based checklists.
    @ateucher
    ateucher committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    c1e74d3 View commit details
    Browse the repository at this point in the history

  9. Add footer to upkeep issue with usethis version

    @ateucher
    ateucher committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    f7cce22 View commit details
    Browse the repository at this point in the history

  10. Mock checklist_footer in tests to avoid spurious snapshot changes

    @ateucher
    ateucher committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    5512557 View commit details
    Browse the repository at this point in the history

  11. Remove superfluous period 

    Co-authored-by: Jennifer (Jenny) Bryan <[email protected]>
    @ateucher @jennybc
    ateucher and jennybc authored Apr 18, 2023
    Configuration menu
    Copy the full SHA
    55f6145 View commit details
    Browse the repository at this point in the history

  12. Only show cran-comments bullet if cran-comments.md exists

    @ateucher
    ateucher committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    add9806 View commit details
    Browse the repository at this point in the history

  13. Use transform in expect_snapshot() instead of local_mocked_bindings()

    @ateucher
    ateucher committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    1fccbb1 View commit details
    Browse the repository at this point in the history

  14. Update snapshot

    @ateucher
    ateucher committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    f5b7083 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. run styler

    @ateucher
    ateucher committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    839a152 View commit details
    Browse the repository at this point in the history

  2. update snapshot (R version changed overnight)

    @ateucher
    ateucher committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    088b56e View commit details
    Browse the repository at this point in the history

  3. Move NEWS bullet to the top as per style guide

    @ateucher
    ateucher committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    288f0cc View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2023

  1. Merge branch 'main' into public-upkeep-checklist

    @ateucher
    ateucher committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    22026bd View commit details
    Browse the repository at this point in the history

  2. suggest use_github_action() unconditionally 

    Co-authored-by: Hadley Wickham <[email protected]>
    @ateucher @hadley
    ateucher and hadley authored Apr 25, 2023
    Configuration menu
    Copy the full SHA
    3fbea04 View commit details
    Browse the repository at this point in the history

  3. remove use_citation() bullet

    @ateucher
    ateucher committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    f769a7e View commit details
    Browse the repository at this point in the history

  4. Add angle brackets to urls

    @ateucher
    ateucher committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    10be9c9 View commit details
    Browse the repository at this point in the history

  5. update tests and snapshots

    @ateucher
    ateucher committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    9003634 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2023

  1. Check cran-comments.md for test environments

    @ateucher
    ateucher committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    4a7708a View commit details
    Browse the repository at this point in the history

  2. More specific check for test env in cran-comments

    @ateucher
    ateucher committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    d360d5a View commit details
    Browse the repository at this point in the history

  3. remove lifecycle bullet from upkeep_checklist()

    @ateucher
    ateucher committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    0d482c5 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into public-upkeep-checklist

    @ateucher
    ateucher committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    c66a147 View commit details
    Browse the repository at this point in the history