chore: upgrade to 1.9.0 #613
Triggered via pull request
August 15, 2024 05:36
chungquantin
chungquantin
synchronize
#179
Status
Success
Total duration
11s
Artifacts
–
lint-pr.yml
on: pull_request_target
Validate PR title for conventional commit compliance
2s
Annotations
5 warnings
|
large size difference between variants:
node/src/cli.rs#L5
warning: large size difference between variants
--> node/src/cli.rs:5:1
|
5 | / pub enum Subcommand {
6 | | /// Build a chain specification.
7 | | BuildSpec(sc_cli::BuildSpecCmd),
... |
19 | | ImportBlocks(sc_cli::ImportBlocksCmd),
| | ------------------------------------- the second-largest variant contains at least 240 bytes
... |
39 | | Benchmark(frame_benchmarking_cli::BenchmarkCmd),
| | ----------------------------------------------- the largest variant contains at least 520 bytes
... |
48 | | Key(sc_cli::KeySubcommand),
49 | | }
| |_^ the entire enum is at least 520 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
= note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
|
39 | Benchmark(Box<frame_benchmarking_cli::BenchmarkCmd>),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
this match could be replaced by its body itself:
runtime/devnet/src/extensions.rs#L186
warning: this match could be replaced by its body itself
--> runtime/devnet/src/extensions.rs:186:15
|
186 | let result = match key {
| __________________^
187 | | _ => Vec::<u8>::default(),
188 | | }
| |_____^ help: consider using the match body instead: `Vec::<u8>::default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding
= note: `#[warn(clippy::match_single_binding)]` on by default
|
|
this match could be replaced by its body itself:
runtime/testnet/src/extensions.rs#L186
warning: this match could be replaced by its body itself
--> runtime/testnet/src/extensions.rs:186:15
|
186 | let result = match key {
| __________________^
187 | | _ => Vec::<u8>::default(),
188 | | }
| |_____^ help: consider using the match body instead: `Vec::<u8>::default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding
= note: `#[warn(clippy::match_single_binding)]` on by default
|
|
bound is defined in more than one place:
runtime/devnet/src/extensions.rs#L33
warning: bound is defined in more than one place
--> runtime/devnet/src/extensions.rs:33:10
|
33 | fn call<E: Ext>(&mut self, env: Environment<E, InitState>) -> Result<RetVal, DispatchError>
| ^
34 | where
35 | E: Ext<T = T>,
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
= note: `#[warn(clippy::multiple_bound_locations)]` on by default
|
|
bound is defined in more than one place:
runtime/testnet/src/extensions.rs#L33
warning: bound is defined in more than one place
--> runtime/testnet/src/extensions.rs:33:10
|
33 | fn call<E: Ext>(&mut self, env: Environment<E, InitState>) -> Result<RetVal, DispatchError>
| ^
34 | where
35 | E: Ext<T = T>,
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
= note: `#[warn(clippy::multiple_bound_locations)]` on by default
|