Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to 1.9.0 #179

Merged
merged 5 commits into from
Aug 15, 2024
Merged

Conversation

chungquantin
Copy link
Collaborator

@chungquantin chungquantin commented Aug 12, 2024

Status: ✅ Tested on my local devnet, testnet => Block production / finalization + submit extrinsic works well.

CHANGELOG

  • PoV Reclaim Runtime Side paritytech/polkadot-sdk#3002 (not included in this upgrade until the POV reclaim feature is merged to the system parachains, see comment)
  • Permissioned contract deployment on a chain
  • Multi-Block-Migrations,poll hook and new System Callbacks (link to prdoc)
  • Removes as [disambiguation_path] from the required syntax in derive_impl

Contracts-Related Changes

#3377 - Permissioned contract deployment

This PR introduces two new config types that specify the origins allowed to upload and instantiate contract code. However, this check is not enforced when a contract instantiates another contract.

Async Backing Issues

@chungquantin chungquantin changed the base branch from main to developer August 12, 2024 09:56
@chungquantin chungquantin mentioned this pull request Aug 12, 2024
7 tasks
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 10.58%. Comparing base (a05d9e7) to head (2352a50).
Report is 1 commits behind head on developer.

Files Patch % Lines
runtime/devnet/src/lib.rs 0.00% 1 Missing ⚠️
runtime/testnet/src/lib.rs 0.00% 1 Missing ⚠️
@@            Coverage Diff             @@
##           developer     #179   +/-   ##
==========================================
  Coverage      10.58%   10.58%           
==========================================
  Files             27       27           
  Lines           2135     2135           
  Branches        2135     2135           
==========================================
  Hits             226      226           
  Misses          1909     1909           
Files Coverage Δ
runtime/devnet/src/config/contracts.rs 60.00% <ø> (ø)
runtime/testnet/src/config/contracts.rs 60.00% <ø> (ø)
runtime/devnet/src/lib.rs 14.88% <0.00%> (ø)
runtime/testnet/src/lib.rs 14.88% <0.00%> (ø)

... and 2 files with indirect coverage changes

@chungquantin chungquantin removed the request for review from evilrobot-01 August 13, 2024 09:43
Copy link
Collaborator

@al3mart al3mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in paritytech/polkadot-sdk#3002 should also be included :)

Maybe only for devnet (polkadot-fellows/runtimes#423)

@chungquantin chungquantin self-assigned this Aug 13, 2024
Copy link
Collaborator

@peterwht peterwht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I see no issues. Validated all PRs from here moondance-labs/tanssi#575

No need to do anything with this, but just documenting the following PR here in-case of async backing issues. paritytech/polkadot-sdk#3510

@peterwht
Copy link
Collaborator

Will integration tests be resolved in a later version?

@peterwht
Copy link
Collaborator

[sc-916]

@chungquantin chungquantin requested a review from al3mart August 14, 2024 03:08
@chungquantin
Copy link
Collaborator Author

Will integration tests be resolved in a later version?

I expect it will be resolved in a PR from 1.13.0 to 1.14.0 if I understand it correctly

@al3mart
Copy link
Collaborator

al3mart commented Aug 14, 2024

Integration tests are blocked until a new release of Paseo is done 🙏

runtime/testnet/src/lib.rs Outdated Show resolved Hide resolved
@chungquantin chungquantin added ready-for-high-level-review and removed bug Something isn't working pending labels Aug 15, 2024
@chungquantin
Copy link
Collaborator Author

POV reclaim feature is removed in this upgrade for both devnet and testnet as discussed.

NOTE: For the POV reclaim feature, it will be cleaner in the next upgrade #182 with the introduction of unified ParachainHostFunctions. Tested the 1.10.0 upgrade and the local network can produce + finalize blocks successfully.

Copy link
Collaborator

@al3mart al3mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow even with the revert the host functions are still expected

Running both devnet and testnet will err with

Error: Service(Client(VersionInvalid("Other error happened while constructing the runtime: runtime requires function imports which are not present on the host: 'env:ext_storage_proof_size_storage_proof_size_version_1'")))
2024-08-15 11:05:16 [Parachain] Cannot create a runtime error=Other("runtime requires function imports which are not present on the host: 'env:ext_storage_proof_size_storage_proof_size_version_1'")

Approving as the objective is updating the codebase to current and it seems 1.10 gets rid of this. 👍

@chungquantin
Copy link
Collaborator Author

Somehow even with the revert the host functions are still expected

Running both devnet and testnet will err with

Error: Service(Client(VersionInvalid("Other error happened while constructing the runtime: runtime requires function imports which are not present on the host: 'env:ext_storage_proof_size_storage_proof_size_version_1'")))
2024-08-15 11:05:16 [Parachain] Cannot create a runtime error=Other("runtime requires function imports which are not present on the host: 'env:ext_storage_proof_size_storage_proof_size_version_1'")

Approving as the objective is updating the codebase to current and it seems 1.10 gets rid of this. 👍

Thank you Ale, I also got this error on my end but with 1.10.0, it is fixed. So I guess this PR is good to be merged to developer first and then 1.10.0 will resolve the issue.

@chungquantin chungquantin merged commit d96b93e into developer Aug 15, 2024
8 of 9 checks passed
@chungquantin chungquantin deleted the chungquantin/chore-polkadot-v1.9.0 branch August 15, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants