Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate remote cards over to zustand <> react-query sync #5796

Merged
merged 31 commits into from
Jun 17, 2024

Conversation

walmat
Copy link
Contributor

@walmat walmat commented May 31, 2024

Fixes RNBW-4745

In attempting to track down frame drops I noticed it's mostly due to high-level component re-renders. This PR will attempt to fix a few pain points:

  • replace remote cards provider with a Zustand <> react-query sync state
  • replace remote promo sheets with a Zustand <> react-query sync state

@walmat walmat requested review from benisgold and jinchung as code owners May 31, 2024 18:29
@walmat walmat marked this pull request as draft May 31, 2024 18:29
@walmat walmat marked this pull request as ready for review June 3, 2024 21:08
@walmat walmat added the performance performance related improvements label Jun 4, 2024
src/App.js Outdated Show resolved Hide resolved
Copy link

linear bot commented Jun 5, 2024

@walmat walmat added the swaps v2 label Jun 6, 2024
}, 10_000);
});
});
}, 10_000);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wowow TIL that in JS 10000 === 10_000 is true 🤯

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whenever I see people arguing about whether or not JavaScript is a good language on Twitter or whatever I cannot help but think about this repo: https://github.com/denysdovhan/wtfjs?tab=readme-ov-file#-examples

Copy link
Member

@christianbaroni christianbaroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than my comments above

@walmat walmat merged commit 23e59ea into develop Jun 17, 2024
6 checks passed
@walmat walmat deleted the @matthew/fix-frame-drops branch June 17, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance performance related improvements swaps v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants