-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate remote cards over to zustand <> react-query sync #5796
Merged
Merged
Changes from 19 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
098b602
migrate remote cards over to zustand <> react-query sync
walmat e6b5fa2
try to fix placement
walmat f6a6657
bring in promo sheets too
walmat db272d5
fix lint
walmat 5988d85
chore: merge
walmat f19b154
Merge branch 'develop' into @matthew/fix-frame-drops
walmat 6251afe
more cleanup
walmat 7f5c9f4
write migration to prevent showing old sheets to users
walmat e8e4de7
bring back discover search
walmat e91ea74
fix e2e
walmat 184e1ea
Update src/resources/cards/cardCollectionQuery.ts
walmat b20aa2c
Merge branch 'develop' into @matthew/fix-frame-drops
walmat a9eaee1
Merge branch 'develop' into @matthew/fix-frame-drops
walmat a685cda
Merge branch 'develop' into @matthew/fix-frame-drops
walmat 895a54b
Merge branch 'develop' into @matthew/fix-frame-drops
walmat d109b95
Merge branch 'develop' into @matthew/fix-frame-drops
walmat b2d6f20
Merge branch 'develop' into @matthew/fix-frame-drops
walmat c931d61
move sync components and memo them
walmat dadf0ab
Merge branch 'develop' into @matthew/fix-frame-drops
walmat ed5c7b8
wrap in IM
walmat 77b4dad
Merge branch 'develop' into @matthew/fix-frame-drops
walmat 49ffa53
Merge branch 'develop' into @matthew/fix-frame-drops
walmat 1e08f97
Merge branch 'develop' into @matthew/fix-frame-drops
walmat c818fd5
Merge branch 'develop' into @matthew/fix-frame-drops
walmat d7eb6d6
Merge branch 'develop' into @matthew/fix-frame-drops
walmat d3519a5
Merge branch 'develop' into @matthew/fix-frame-drops
walmat 5046499
Merge branch 'develop' into @matthew/fix-frame-drops
walmat c68eaa3
Merge branch 'develop' into @matthew/fix-frame-drops
walmat 3749f84
cleanup discover home and revert scroll throttle change
walmat 7229bda
rm reactive cards in remote card
walmat 0259898
change refetch interval
walmat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,2 @@ | ||
export * from './RemoteCardProvider'; | ||
export * from './RemoteCard'; | ||
export * from './RemoteCardCarousel'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wowow TIL that in JS
10000 === 10_000
istrue
🤯There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whenever I see people arguing about whether or not JavaScript is a good language on Twitter or whatever I cannot help but think about this repo: https://github.com/denysdovhan/wtfjs?tab=readme-ov-file#-examples