Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use API refresh logic on image upload #1147

Open
joelvdavies opened this issue Dec 5, 2024 · 0 comments · May be fixed by #1152
Open

Use API refresh logic on image upload #1147

joelvdavies opened this issue Dec 5, 2024 · 0 comments · May be fixed by #1152
Assignees
@joshuadkitenge
Labels
bug Something isn't working enhancement Improved or refactored feature

Comments

@joelvdavies
Copy link
Collaborator

See comment here: #1145 (comment). If the token times out while uploading, it wont refresh when uploading images using uppy as that logic is handled by axios which it doesn't use.

I think it would be worth moving this logic into the API, along with any query invalidation when doing this to ensure the logic is kept together.
@joelvdavies joelvdavies added bug Something isn't working enhancement Improved or refactored feature labels Dec 5, 2024
@joelvdavies joelvdavies mentioned this issue Dec 5, 2024
Merged
3 tasks
@joshuadkitenge joshuadkitenge self-assigned this Dec 10, 2024
@joshuadkitenge joshuadkitenge linked a pull request Dec 11, 2024 that will close this issue
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshuadkitenge joshuadkitenge

Labels
bug Something isn't working enhancement Improved or refactored feature
Projects
Inventory Management System
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Uppy refresh token logic ral-facilities/inventory-management-system
2 participants
@joshuadkitenge @joelvdavies