Add Avro Reader options classes to pylibcudf #17599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matt711
added
feature request
github-actions
bot
added
Python
Matt711
commented
Dec 16, 2024
| skip_rows: int = 0, | ||
| num_rows: int = -1, | ||
| ) -> TableWithMetadata: ... | ||
| __all__ = ["AvroReaderOptions", "AvroReaderOptionsBuilder", "read_avro"] |
There was a problem hiding this comment.
I don't see __all__'s in other type stub files. Should it be included?
There was a problem hiding this comment.
IMO yes, ideally the stubs should also have __all__
There was a problem hiding this comment.
Ok, will follow up to add __all__
mroeschke
reviewed
Dec 16, 2024
mroeschke
approved these changes
Dec 17, 2024
|
/merge |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apart of #17565
Checklist