-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Avro Reader options classes to pylibcudf #17599
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,23 @@ | ||
# Copyright (c) 2024, NVIDIA CORPORATION. | ||
from pylibcudf.io.types cimport SourceInfo, TableWithMetadata | ||
from pylibcudf.libcudf.io.avro cimport avro_reader_options | ||
from pylibcudf.libcudf.io.avro cimport avro_reader_options, avro_reader_options_builder | ||
from pylibcudf.libcudf.types cimport size_type | ||
|
||
|
||
cpdef TableWithMetadata read_avro( | ||
SourceInfo source_info, | ||
list columns = *, | ||
size_type skip_rows = *, | ||
size_type num_rows = * | ||
) | ||
from pylibcudf.libcudf.types cimport size_type | ||
|
||
cdef class AvroReaderOptions: | ||
cdef avro_reader_options c_obj | ||
cdef SourceInfo source | ||
cpdef void set_columns(self, list col_names) | ||
|
||
|
||
cdef class AvroReaderOptionsBuilder: | ||
cdef avro_reader_options_builder c_obj | ||
cdef SourceInfo source | ||
cpdef AvroReaderOptionsBuilder columns(self, list col_names) | ||
cpdef AvroReaderOptionsBuilder skip_rows(self, size_type skip_rows) | ||
cpdef AvroReaderOptionsBuilder num_rows(self, size_type num_rows) | ||
cpdef AvroReaderOptions build(self) | ||
|
||
cpdef TableWithMetadata read_avro(AvroReaderOptions options) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,16 @@ | ||
# Copyright (c) 2024, NVIDIA CORPORATION. | ||
from pylibcudf.io.types import SourceInfo, TableWithMetadata | ||
|
||
__all__ = ["read_avro"] | ||
|
||
def read_avro( | ||
source_info: SourceInfo, | ||
columns: list[str] | None = None, | ||
skip_rows: int = 0, | ||
num_rows: int = -1, | ||
) -> TableWithMetadata: ... | ||
__all__ = ["AvroReaderOptions", "AvroReaderOptionsBuilder", "read_avro"] | ||
|
||
class AvroReaderOptions: | ||
@staticmethod | ||
def builder(source: SourceInfo) -> AvroReaderOptionsBuilder: ... | ||
|
||
class AvroReaderOptionsBuilder: | ||
def columns(col_names: list[str]) -> AvroReaderOptionsBuilder: ... | ||
def skip_rows(skip_rows: int) -> AvroReaderOptionsBuilder: ... | ||
def num_rows(num_rows: int) -> AvroReaderOptionsBuilder: ... | ||
def build(self) -> AvroReaderOptions: ... | ||
|
||
def read_avro(options: AvroReaderOptions) -> TableWithMetadata: ... |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see
__all__
's in other type stub files. Should it be included?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO yes, ideally the stubs should also have
__all__
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, will follow up to add
__all__