-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove all remaining uses of cugraph-ops #4784
remove all remaining uses of cugraph-ops #4784
Conversation
Hopefully rapidsai/devcontainers#423 will fix the devcontainer CI jobs here. |
.github/workflows/pr.yaml
Outdated
@@ -49,7 +49,7 @@ jobs: | |||
files_yaml: | | |||
test_cpp: | |||
- '**' | |||
- '!.devcontainers/**' | |||
- '!.devcontainer/**' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unrelated to cugraph-ops
, but just slipping it in here because it's not worth a full CI run on its own.
This repo doesn't have a .devcontainers/
directory... it's called .devcontainer/
.
It looks to me like the
That's coming from here: Lines 56 to 61 in 1f1cace
@alexbarghi-nv @acostadon can you help with this? |
WholeGraph docs are supposed to move to the docs repo, not |
Sure, works for me. I just pushed c1f4e56 doing that. |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python looks good.👍
Thanks everyone! There's just 1 test job left, so I'm going to queue this for auto-merge. |
/merge |
This repo should no longer need any build-time dependencies on cloning the
cugraph-ops
source code or pulling in its packages, as of these PRs:This PR proposes the following:
cugraph-ops
repocugraph-ops
ALLOW_CLONE_CUGRAPH_OPS
CUGRAPH_EXCLUDE_CUGRAPH_OPS_FROM_ALL
CUGRAPH_USE_CUGRAPH_OPS_STATIC
USE_CUGRAPH_OPS
pylibcugraphops
/libcugraphops
in development scripts, conda recipescugraph-ops
docs, and references to them in other docscpp/src/utilities/cugraph_ops_utils.hpp
cugraph_ops
pytest markerNotes for Reviewers
Benefits of these changes
libcugraph
wheel packages (https://github.com/rapidsai/rapids-wheels-planning/issues/53)How I identified these changes
Why is this so big?
I'd originally wanted to leave the docs-building stuff in place, but saw
docs-build
CI here failing because docs haven't been built from thecugraph-ops
repo yet:cugraph/build.sh
Lines 334 to 341 in c5d3d23
Talked offline with @acostadon and @ChuckHastings , and we agreed that those docs could just be removed here.
What is intentionally being left?
cugraph-ops
is vendored here)cugraph-dgl
,cugraph-pyg
,pylibwholegraph
), as those do still rely oncugraph-ops
(their docs will eventually move out of this repo)