Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to rmm logger changes #4794

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Nov 27, 2024

This PR adapts to breaking changes in rmm in rapidsai/rmm#1722.

@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 27, 2024
@vyasr vyasr self-assigned this Nov 27, 2024
@vyasr vyasr requested a review from a team as a code owner November 27, 2024 23:50
@vyasr vyasr requested review from a team as code owners November 28, 2024 05:12
@vyasr vyasr requested a review from raydouglass November 28, 2024 05:12
@github-actions github-actions bot added the ci label Nov 28, 2024
@vyasr
Copy link
Contributor Author

vyasr commented Nov 28, 2024

I cherry picked @jameslamb 's commit from #4784 to disable the docs builds.

Copy link
Contributor

@acostadon acostadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling is fine.

@vyasr
Copy link
Contributor Author

vyasr commented Dec 2, 2024

/merge

@rapids-bot rapids-bot bot merged commit 98023d7 into rapidsai:branch-25.02 Dec 2, 2024
76 of 82 checks passed
@vyasr vyasr deleted the feat/rmm_logger branch December 2, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CMake cuGraph improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants