Add missing setuptools to conda recipe
#1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pentschev
added
bug
jameslamb
reviewed
Dec 17, 2024
conda/recipes/dask-cuda/meta.yaml
Outdated
| @@ -30,6 +30,7 @@ requirements: | |||
| - python | |||
| - pip | |||
| - rapids-build-backend>=0.3.0,<0.4.0.dev0 | |||
| - setuptools | |||
There was a problem hiding this comment.
Suggested change
| - setuptools | |
| - setuptools>=64.0.0 |
Let's please match the floor in
Line 78 in d70f28d
Somewhere around the 64.0.0 release (don't remember exactly where) is where setuptools added support for pyproject.toml, which we rely on.
jameslamb
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Thanks! I think this will fix the issue you observed in https://github.com/rapidsai/dask-cuda/actions/runs/12366711202/job/34513856325.
And is appropriate given that setuptools is the backend for this package:
Line 137 in d70f28d
I guess we must have been getting it transitively from other packages before.
|
Thanks @jameslamb ! |
|
/merge |
bdice
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conda builds are failing due to missing
setuptools, this change add the missing dependency to fix the failure.