Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI test linux://python/ray/dag:test_torch_tensor_dag_gpu is flaky #45920

Closed
can-anyscale opened this issue Jun 13, 2024 · 69 comments · Fixed by #48204
Closed

CI test linux://python/ray/dag:test_torch_tensor_dag_gpu is flaky #45920

can-anyscale opened this issue Jun 13, 2024 · 69 comments · Fixed by #48204
Assignees
@ruisearch42
Labels
bug Something that is supposed to be working; but isn't ci-test core Issues that should be addressed in Ray Core stability triage Needs triage (eg: priority, bug/not-bug, and owning component)

Comments

@can-anyscale
Copy link
Collaborator

CI test linux://python/ray/dag:test_torch_tensor_dag_gpu is consistently_failing. Recent failures:
- https://buildkite.com/ray-project/postmerge/builds/4886#01901018-8a42-41d5-9187-e980a86df6a9
- https://buildkite.com/ray-project/postmerge/builds/4886#01901003-09d9-4c74-bfa0-32c5f0e33dea

DataCaseName-linux://python/ray/dag:test_torch_tensor_dag_gpu-END
Managed by OSS Test Policy
@can-anyscale can-anyscale added bug Something that is supposed to be working; but isn't ci-test core Issues that should be addressed in Ray Core flaky-tracker Issue created via Flaky Test Tracker https://flaky-tests.ray.io/ ray-test-bot Issues managed by OSS test policy stability triage Needs triage (eg: priority, bug/not-bug, and owning component) weekly-release-blocker Issues that will be blocking Ray weekly releases labels Jun 13, 2024
@aslonnie aslonnie mentioned this issue Jun 13, 2024
Merged
@can-anyscale
Copy link
Collaborator Author

Blamed commit: d577652 found by bisect job https://buildkite.com/ray-project/release-tests-bisect/builds/1228

@can-anyscale
Copy link
Collaborator Author

blame reverted

@can-anyscale
Copy link
Collaborator Author

This test is now considered as flaky because it has been failing on postmerge for too long. Flaky tests do not run on premerge.

1 similar comment
@can-anyscale
Copy link
Collaborator Author

This test is now considered as flaky because it has been failing on postmerge for too long. Flaky tests do not run on premerge.

@can-anyscale
Copy link
Collaborator Author

can-anyscale commented Jun 15, 2024 •
edited
Loading

still failing; but likely not release blocking, let's confirm on Monday

@can-anyscale can-anyscale reopened this Jun 15, 2024
@kevin85421
Copy link
Member

The error seems to be related to dependency conflicts.

Screenshot 2024-06-15 at 10 17 06 AM

@can-anyscale
Copy link
Collaborator Author

@kevin85421 given that dag is still in experimental state, i'm assuming this is not a release blocker, can you or @stephanie-wang confirm? thanks

@kevin85421
Copy link
Member

@can-anyscale Where is the error message? I am not sure whether the issue is actually related to the ADAG, as the CI error indicates a dependency conflict.

can you or @stephanie-wang confirm?

Wait for Stephanie to confirm.

@can-anyscale
Copy link
Collaborator Author

@kevin85421 thankks, error message: https://buildkite.com/ray-project/postmerge/builds/4953#01901a79-80f5-413d-85db-510a68adfcf3/176-5839

@kevin85421
Copy link
Member

The master branch seems to have several ongoing revert PRs. Let's check whether it will still happen after #46066 is merged. cc @ruisearch42

@ruisearch42
Copy link
Contributor

ruisearch42 commented Jun 15, 2024 via email

@can-anyscale
Copy link
Collaborator Author

this test is actually passing https://buildkite.com/ray-project/postmerge/builds/4965#01901d46-444f-431c-a29c-225dc3291f40, but i'll wait for automation to close it

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/4999#019028aa-c3ac-43d7-8bf0-bdcf2ab1cc9a

@can-anyscale can-anyscale reopened this Sep 7, 2024
@can-anyscale
Copy link
Collaborator Author

CI test linux://python/ray/dag:test_torch_tensor_dag_gpu is consistently_failing. Recent failures:
- https://buildkite.com/ray-project/postmerge/builds/6172#0191cb01-301c-4586-9acd-72aedb17b55d
- https://buildkite.com/ray-project/postmerge/builds/6172#0191cae0-e5e6-4705-abf8-08e9a7995437
- https://buildkite.com/ray-project/postmerge/builds/6171#0191c9d0-2e51-4144-99c9-9e0fd2cc4e10

DataCaseName-linux://python/ray/dag:test_torch_tensor_dag_gpu-END
Managed by OSS Test Policy

1 similar comment
@can-anyscale
Copy link
Collaborator Author

CI test linux://python/ray/dag:test_torch_tensor_dag_gpu is consistently_failing. Recent failures:
- https://buildkite.com/ray-project/postmerge/builds/6172#0191cb01-301c-4586-9acd-72aedb17b55d
- https://buildkite.com/ray-project/postmerge/builds/6172#0191cae0-e5e6-4705-abf8-08e9a7995437
- https://buildkite.com/ray-project/postmerge/builds/6171#0191c9d0-2e51-4144-99c9-9e0fd2cc4e10

DataCaseName-linux://python/ray/dag:test_torch_tensor_dag_gpu-END
Managed by OSS Test Policy

@can-anyscale can-anyscale reopened this Oct 25, 2024
@can-anyscale
Copy link
Collaborator Author

CI test linux://python/ray/dag:test_torch_tensor_dag_gpu is flaky. Recent failures:
- https://buildkite.com/ray-project/postmerge/builds/6679#0192c213-a953-4170-b37f-c8e3c1c206f5
- https://buildkite.com/ray-project/postmerge/builds/6636#0192b7e1-223a-470e-8e70-0f437cc9e859
- https://buildkite.com/ray-project/postmerge/builds/6636#0192b7c5-97f6-4c97-b8c9-bfe9be4419c0
- https://buildkite.com/ray-project/postmerge/builds/6627#0192b51a-6076-4e99-943d-2fc9e62acba7
- https://buildkite.com/ray-project/postmerge/builds/6627#0192b4fd-42e6-4bb3-b2ba-422778386168

DataCaseName-linux://python/ray/dag:test_torch_tensor_dag_gpu-END
Managed by OSS Test Policy

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/6705#0192d3e2-fd60-4670-824b-dbc079cd77bd

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/6721#0192d6ab-d4be-40ec-9a89-a5a0eee4e38f

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/6727#0192d909-7584-4714-b027-623c55076c3e

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/6741#0192d9e4-a901-4ee4-af2c-b5a868e5fc8b

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/6748#0192dabe-9273-42f7-b416-4ea69b54f35c

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/6755#0192dbd2-44b3-49f3-8e8c-2c2bab094167

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/6759#0192de2f-e4de-4a07-ac60-750f63fd4673

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/6764#0192df0b-aa05-4403-b634-5c54d83336d8

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/6769#0192dfe7-fe96-4bb3-b8dc-0c85cf624977

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/6772#0192e0f9-6b2b-4fc6-94bb-bd8853945202

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/6780#0192e356-bb62-4613-897f-591b764d6460

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/6785#0192e430-a54c-482f-b849-2718cd23d16b

@rkooo567 rkooo567 removed flaky-tracker Issue created via Flaky Test Tracker https://flaky-tests.ray.io/ weekly-release-blocker Issues that will be blocking Ray weekly releases labels Oct 31, 2024
@rkooo567
Copy link
Contributor

@can-anyscale idk why it keeps saying this, but I Removed some suspcious labels!

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/7023#01934b64-f511-4129-966b-76334c355445

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/7029#01934c43-693e-424c-b6d7-23880124b2bc

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/7032#01934d55-90ca-4048-9ea2-696a865c0262

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/7036#01934faf-4789-404c-8c0f-cc3a7833f59f

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/7039#0193508d-72de-47e7-9803-2cc43a803a40

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/7044#0193516b-8257-4fd0-ac81-051b99e61199

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/7048#0193527d-0031-4e6e-9b54-29e1532d49ab

@rkooo567 rkooo567 removed the ray-test-bot Issues managed by OSS test policy label Nov 22, 2024
@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/7052#019354d8-309e-4020-804a-c05b2d80efd1

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/7059#019355b2-b215-40ac-92cb-7f2ea91cee2b

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/7064#0193568c-f5a8-445a-876c-add84c65dda1

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/7069#019357a1-68d9-4895-83ea-8de501a57a41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruisearch42 ruisearch42

Labels
bug Something that is supposed to be working; but isn't ci-test core Issues that should be addressed in Ray Core stability triage Needs triage (eg: priority, bug/not-bug, and owning component)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[core][compiled graphs] Fix test_torch_tensor_dag_gpu CI failure ruisearch42/ray
6 participants
@stephanie-wang @rkooo567 @kevin85421 @dengwxn @can-anyscale @ruisearch42