-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: modify phone number module core engine for more accurate results [ATLAS-194] #123
Conversation
|
This comment has been minimized.
This comment has been minimized.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #123 +/- ##
==========================================
+ Coverage 95.00% 95.29% +0.28%
==========================================
Files 44 44
Lines 501 489 -12
Branches 128 122 -6
==========================================
- Hits 476 466 -10
+ Misses 24 23 -1
+ Partials 1 0 -1 ☔ View full report in Codecov by Sentry. |
Bundle Size Report
|
🟢 No Change | 🗑 File Deleted | 🆕 New File | 📈 Size Increased | 👍 Size Reduced |
---|
Parsed (kb) | |||||
---|---|---|---|---|---|
🚦 | File Name | Base | PR | Diff | % |
👍 | cjs/index.js |
165.21 |
164.27 |
|
-0.57 |
👍 | esm/index.min.js |
52.5 |
52.33 |
|
-0.32 |
👍 | umd/index.js |
181.88 |
180.84 |
|
-0.57 |
This comment has been minimized.
This comment has been minimized.
…honeNumber-engine
Unit Test Results0 files 0 suites 0s ⏱️ Results for commit 75abff9. |
Description
For cases where country code and dial code both of these are not provided phone number module produces incorrect results sometimes due to the fact that same regex can work for phone numbers of different countries. This PR fixes this issue.
Changes Made
List the main changes made in this pull request.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Additional Notes
Any additional information that would be helpful for the reviewer.
Checklist:
Reviewer Checklist
PR Title Format
Format:
<type>: <subject>
Types can be as follows:
feat
: (new feature for the user, not a new feature for build script)fix
: (bug fix for the user, not a fix to a build script)docs
: (changes to the documentation)style
: (formatting, missing semi colons, etc; no production code change)refactor
: (refactoring production code, eg. renaming a variable)test
: (adding missing tests, refactoring tests; no production code change)chore
: (updating grunt tasks etc; no production code change)