fix: modify phone number module core engine for more accurate results [ATLAS-194]

packages/i18nify-js/src/modules/phoneNumber/__tests__/detectCountryAndDialCodeFromPhone.test.ts

@@ -6,7 +6,7 @@ describe('detectCountryAndDialCodeFromPhone', () => {
       countryCode: 'IN',
       dialCode: '+91',
     });
-    expect(detectCountryAndDialCodeFromPhone('60123456789')).toEqual({
+    expect(detectCountryAndDialCodeFromPhone('+60123456789')).toEqual({
       countryCode: 'MY',
       dialCode: '+60',
     });

packages/i18nify-js/src/modules/phoneNumber/__tests__/isValidPhoneNumber.test.ts

@@ -35,7 +35,7 @@ describe('isValidPhoneNumber', () => {
     const phoneNumber = '1234567890';
     const countryCode = 'XYZ';
     const isValid = isValidPhoneNumber(phoneNumber, countryCode as any);
-    expect(isValid).toBe(true);
+    expect(isValid).toBe(false);
   });
 
   it('should handle a missing phoneNumber', () => {

packages/i18nify-js/src/modules/phoneNumber/utils.ts

@@ -9,8 +9,7 @@ import { PHONE_REGEX_MAPPER } from './data/phoneRegexMapper';
  *   and matches the leading digits with known dial codes mapped to countries.
  * - For matched dial codes, it further filters based on country-specific regex patterns
  *   to validate the phone number format for those countries.
- * - If the phone number doesn't start with '+', it directly matches the number
- *   against regular expressions associated with various countries to identify the code.
+ * - If the phone number doesn't start with '+', it returns empty strings as dialCode and countryCode
  *
  * @param phoneNumber The input phone number (string or number).
  * @returns The detected countryCode & dialCode or an empty strings in both if not found.
@@ -55,19 +54,6 @@ export const detectCountryAndDialCodeFromPhone = (
         dialCode: '',
       }
     );
-  } else {
-    // If phone number doesn't start with '+', directly match against country regexes
-    for (const countryCode in PHONE_REGEX_MAPPER) {
-      const regex = PHONE_REGEX_MAPPER[countryCode as CountryCodeType];
-      if (regex.test(phoneNumber.toString())) {
-        return {
-          countryCode: countryCode as CountryCodeType,
-          dialCode: getDialCodeFromCountryCode(countryCode as CountryCodeType)
-            ? `+${getDialCodeFromCountryCode(countryCode as CountryCodeType)}`
-            : '',
-        };
-      }
-    }
   }
 
   // Return empty string if no country code is detected
@@ -81,21 +67,3 @@ export const cleanPhoneNumber = (phoneNumber: string) => {
   const cleanedPhoneNumber = phoneNumber.replace(regex, '');
   return phoneNumber[0] === '+' ? `+${cleanedPhoneNumber}` : cleanedPhoneNumber;
 };
-
-/**
- * Returns the dial code mapped for the country code passed from DIAL_CODE_MAPPER
- */
-export const getDialCodeFromCountryCode = (
-  countryCode: CountryCodeType,
-): string => {
-  for (const dialCode in DIAL_CODE_MAPPER) {
-    if (
-      DIAL_CODE_MAPPER[dialCode].includes(
-        countryCode.toUpperCase() as CountryCodeType,
-      )
-    ) {
-      return dialCode;
-    }
-  }
-  return '';
-};