Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Significant refactor to include geographical boundaries #565

Merged
merged 99 commits into from
Sep 9, 2023
Merged

Significant refactor to include geographical boundaries #565

merged 99 commits into from
Sep 9, 2023

Conversation

anchit-chandran
Copy link
Collaborator

@anchit-chandran anchit-chandran commented Sep 7, 2023 •
edited
Loading

NOTE: ❗this is expected to break development due to the significant model refactors, however, with the move to a VPS, this update will be necessary anyway

Significant refactor to all geographical entity models to include more details.

Took this opportunity to also homogenise naming of multiple model attributes

@anchit-chandran
improves docstrings org view indiv kpi
a0e11ba 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
hoverlabel updates
7743488 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
rms lots of prev agg code
4117056 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
rm unused imports report queries
59d7972 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
restructure org view file
fdd3707 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
refactors updating all data chart html out of view into fn
76e0a62 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
actually returns all_data obj from update chart html fn
baad5c0 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
adds download full e12 user list button with test
dd47309 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
initial struct for cohort calc test
e9fe89f 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
merges duplicate community paeds + hospitals in rcpch_organisations
07604bf 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
don't calc avg line if no data (avoid zero division error)
5deb47f 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
make national kpi pie clickable_card
5643436 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
change distribution by ethnicity to rcpch_light_blue card
411d3ae 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
updates cohort num calcs
3ce7ae7 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
rm cohort txt
93c2740 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
clean cohort num file
9a8043d 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
rm print statement score kpi 8
5f14faf 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
change seed to known 5 orgs
0e7b986 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
clean test get filtered cases
3c296eb 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
clean test update kpiagg
6312df9 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
adds orgs to seed
e94d78f 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
adds update all agg models view + button
c544b9b 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
further implements aggregate button front-end
c4f9a7f 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
rm validation comment in case model
9fae26b 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
handles welsh + icb aggs, adds helper destroy+reseed agg funtions
f4f915f 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
make bar charts integer passed pct instead of float
377ea06 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
restyle cohort stats
b92d117 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
group order bar charts by none, then numericla
6faa55d 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
fix type hint
edf89aa 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
allows abstractions to be specified aggregate_by
a7f9b89 
Signed-off-by: anchit-chandran <[email protected]>
eatyourpeas and others added 9 commits September 7, 2023 09:01
@eatyourpeas
no postcode fix
e490773
@eatyourpeas
update transfer email to remove child
588c9c2 
remove ability to edit lead site
@anchit-chandran
add cohort to str reprs of kpiagg models
57c13f7 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
make indv pie chart cards all same set height
6864761 
Signed-off-by: anchit-chandran <[email protected]>
@eatyourpeas
comment out DRF
3eebf93
@anchit-chandran
kpi agg model method to calc total cases handle none
6ead1aa 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
adjust stylings for indv kpi pies when no data
c0d9b9a 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
Merge branch 'health-boards' of https://github.com/rcpch/rcpch-audit-…
69e6702 
…engine into health-boards
@anchit-chandran
make bar text darker for bar charts with None data
7c6d98a 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran anchit-chandran marked this pull request as draft September 7, 2023 14:23
@eatyourpeas
change mental_health_issue to mental_health_issues
cd2f1a5 
change from single choice to multiple choice
@eatyourpeas eatyourpeas temporarily deployed to development September 8, 2023 22:37 — with GitHub Actions Inactive
@eatyourpeas
confirm delete modal for case
eec5ddd 
involves test refactor for permissions to accept htmx params
@eatyourpeas eatyourpeas temporarily deployed to development September 9, 2023 10:50 — with GitHub Actions Inactive
@eatyourpeas
fix email resend
f05e2c3 
- only shows if emailConfirmed is false
- url fail fix
@eatyourpeas eatyourpeas temporarily deployed to development September 9, 2023 11:18 — with GitHub Actions Inactive
@eatyourpeas
remove previous user creation forms
0ab3b56 
- fix user workflow
- hide resend email button if confirmed
@eatyourpeas eatyourpeas temporarily deployed to development September 9, 2023 12:10 — with GitHub Actions Inactive
@eatyourpeas
stub out tests
043eb3f 
remove commented out code
@eatyourpeas eatyourpeas temporarily deployed to development September 9, 2023 13:33 — with GitHub Actions Inactive
@eatyourpeas eatyourpeas marked this pull request as ready for review September 9, 2023 13:34
@eatyourpeas eatyourpeas temporarily deployed to development September 9, 2023 13:36 — with GitHub Actions Inactive
@eatyourpeas eatyourpeas self-assigned this Sep 9, 2023
eatyourpeas
eatyourpeas approved these changes Sep 9, 2023
View reviewed changes
Copy link
Member

@eatyourpeas eatyourpeas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a large PR and has fixes for several other issues in it besides the refactor.
Main thing is all tests are passing.

@eatyourpeas eatyourpeas merged commit 10ce5bf into development Sep 9, 2023
1 check passed
@eatyourpeas eatyourpeas deleted the health-boards branch September 9, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eatyourpeas eatyourpeas eatyourpeas approved these changes

@pacharanero pacharanero Awaiting requested review from pacharanero

Assignees

@eatyourpeas eatyourpeas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anchit-chandran @eatyourpeas