Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated locators for Verify RHODS Accept Multiple Admin Groups And CR… #2130

Conversation

asanzgom
Copy link
Contributor

…D Gets Updates

@@ -21,7 +21,7 @@
Add OpenShift Groups To Data Science Administrators
[Documentation] Add OpenShift Groups to Data Science administrators From RHODS Dashboard
[Arguments] @{admin_groups}
Click Button ${ADMIN_GROUPS_SECTION}//button[@aria-label="Options menu"]
Click Button ${ADMIN_GROUPS_SECTION}//button[@aria-label="Select the OpenShift groups that contain all Data Science administrators."]

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (139/120)
@@ -34,7 +34,7 @@
Add OpenShift Groups To Data Science User Groups
[Documentation] Add OpenShift Groups to Data Science User From RHODS Dashboard
[Arguments] @{user_groups}
Click Button ${USER_GROUPS_SECTION}//button[@aria-label="Options menu"]
Click Button ${USER_GROUPS_SECTION}//button[@aria-label="Select the OpenShift groups that contain all Data Science users."]

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (129/120)
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
588 0 0 588 100

@asanzgom
Copy link
Contributor Author

rhoai-test-flow/2063/ passed successfully

@@ -55,7 +55,7 @@
IF ${settings_should_be}
# Wait up to 2 minutes as a workaround for bug RHOAIENG-11116
Menu.Navigate To Page Settings User management timeout=2m
Wait Until Element Is Visible //button[@aria-label="Options menu"] timeout=10s
Wait Until Element Is Visible //button[@aria-label="Select the OpenShift groups that contain all Data Science administrators."] timeout=10s

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (153/120)
@asanzgom asanzgom merged commit e3444d4 into red-hat-data-services:master Dec 11, 2024
11 checks passed
@asanzgom asanzgom deleted the hotfix/Verify_RHODS_Accept_Multiple_Admin_Groups_And_CRD_Gets_Updates branch December 11, 2024 10:25
Copy link
Contributor

@MarianMacik MarianMacik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants