Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated locators for Verify RHODS Accept Multiple Admin Groups And CR… #2130

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Updated locators for Verify RHODS Accept Multiple Admin Groups And CR… #2130

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e92d569
Updated locators for Verify RHODS Accept Multiple Admin Groups And CR…
asanzgom Dec 10, 2024
170b8f3
removed comment
asanzgom Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDashboardSettings.resource
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
Add OpenShift Groups To Data Science Administrators
[Documentation] Add OpenShift Groups to Data Science administrators From RHODS Dashboard
[Arguments] @{admin_groups}
Click Button ${ADMIN_GROUPS_SECTION}//button[@aria-label="Options menu"]
Click Button ${ADMIN_GROUPS_SECTION}//button[@aria-label="Select the OpenShift groups that contain all Data Science administrators."]

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (139/120)
FOR ${group} IN @{admin_groups}
${present}= Run Keyword And Return Status Element Should Be Visible
... ${ADMIN_GROUPS_LIST}//*[text()="${group}"]
Expand All @@ -34,7 +34,7 @@
Add OpenShift Groups To Data Science User Groups
[Documentation] Add OpenShift Groups to Data Science User From RHODS Dashboard
[Arguments] @{user_groups}
Click Button ${USER_GROUPS_SECTION}//button[@aria-label="Options menu"]
Click Button ${USER_GROUPS_SECTION}//button[@aria-label="Select the OpenShift groups that contain all Data Science users."]

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (129/120)
FOR ${group} IN @{user_groups}
${present}= Run Keyword And Return Status Element Should Be Visible
... ${USER_GROUPS_LIST}//*[text()="${group}"]
Expand All @@ -55,7 +55,7 @@
IF ${settings_should_be}
# Wait up to 2 minutes as a workaround for bug RHOAIENG-11116
Menu.Navigate To Page Settings User management timeout=2m
Wait Until Element Is Visible //button[@aria-label="Options menu"] timeout=10s
Wait Until Element Is Visible //button[@aria-label="Select the OpenShift groups that contain all Data Science administrators."] timeout=10s # This locator is failing
Fixed Show fixed Hide fixed
ELSE
Verify Cluster Settings Is Not Available
END
Expand Down
2 changes: 1 addition & 1 deletion ods_ci/tests/Tests/0200__rhoai_upgrade/0201__pre_upgrade.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ Setting Pod Toleration Via UI
Verify RHODS Accept Multiple Admin Groups And CRD Gets Updates
[Documentation] Verify that users can set multiple admin groups and
... check OdhDashboardConfig CRD gets updated according to Admin UI
[Tags] Upgrade AutomationBug RHOAIENG-14306
[Tags] Upgrade RHOAIENG-14306
[Setup] Begin Web Test
# robocop: disable
Launch Dashboard And Check User Management Option Is Available For The User
Expand Down
2 changes: 1 addition & 1 deletion ods_ci/tests/Tests/0200__rhoai_upgrade/0203__post_upgrade.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ Verify Pod Toleration

Verify RHODS User Groups
[Documentation] Verify User Configuration after the upgrade
[Tags] Upgrade AutomationBug
[Tags] Upgrade
${admin} Set Variable ${payload[0]['spec']['groupsConfig']['adminGroups']}
${user} Set Variable ${payload[0]['spec']['groupsConfig']['allowedGroups']}
Should Be Equal As Strings '${admin}' 'rhods-admins,rhods-users'
Expand Down
Loading