[OPENJDK-2722] Split the tests inside openjdk_s2i.feature to couple them with appropriate modules #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riate modules Signed-off-by: Jayashree Huttanagoudar <[email protected]>
jhuttana
changed the title
|
Please change the subject tag for this PR to OPENJDK-2722 and add a link to the JIRA in the description. Thanks! |
jmtd
reviewed
Mar 19, 2024
| @ubi8/openjdk-11 | ||
| @ubi8/openjdk-17 | ||
| @ubi8/openjdk-21 | ||
| Feature: JVM Performance tests |
There was a problem hiding this comment.
This isn't a performance test. it was originally added as a regression test for https://issues.redhat.com/browse/CLOUD-2070, and relates to permissions issues for a running user.
The test also is broken at the moment for unknown reasons. the code it was testing was related to changing permissions on /etc/passwd and has been removed. I think we should just delete this test please.
jhuttana
changed the title
Signed-off-by: Jayashree Huttanagoudar <[email protected]>
jmtd
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could you please review the changes?
JIRA: https://issues.redhat.com/browse/OPENJDK-2722