Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPENJDK-2722] Split the tests inside openjdk_s2i.feature to couple them with appropriate modules #463

Merged
merged 2 commits into from
Mar 20, 2024
Merged

[OPENJDK-2722] Split the tests inside openjdk_s2i.feature to couple them with appropriate modules #463

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fdb311
Split the tests inside openjdk_s2i.feature to couple them with approp…
jhuttana Mar 15, 2024
c6bf137
Address review comments
jhuttana Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions modules/jvm/api/tests/features/performance.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# builder only
@ubi8/openjdk-11
@ubi8/openjdk-17
@ubi8/openjdk-21
Feature: JVM Performance tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a performance test. it was originally added as a regression test for https://issues.redhat.com/browse/CLOUD-2070, and relates to permissions issues for a running user.
The test also is broken at the moment for unknown reasons. the code it was testing was related to changing permissions on /etc/passwd and has been removed. I think we should just delete this test please.


@ubi8/openjdk-8
# temporarily marking 'ignore' so these tests are skipped on GHA
# See: https://issues.redhat.com/browse/OPENJDK-2602
@ignore
Scenario: Check java perf dir owned by jboss (CLOUD-2070)
Given s2i build https://github.com/jboss-container-images/openjdk-test-applications from undertow-servlet
Then run jstat -gc 1 1000 1 in container and check its output for S0C
And run stat --printf="%U %G" /tmp/hsperfdata_jboss/ in container and check its output for jboss root
11 changes: 1 addition & 10 deletions tests/features/java/openjdk_s2i.feature → ...i/tests/features/java_s2i_quarkus.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,7 @@
@ubi8/openjdk-11
@ubi8/openjdk-17
@ubi8/openjdk-21
Feature: Openshift OpenJDK-only S2I tests

@ubi8/openjdk-8
# temporarily marking 'ignore' so these tests are skipped on GHA
# See: https://issues.redhat.com/browse/OPENJDK-2602
@ignore
Scenario: Check java perf dir owned by jboss (CLOUD-2070)
Given s2i build https://github.com/jboss-container-images/openjdk-test-applications from undertow-servlet
Then run jstat -gc 1 1000 1 in container and check its output for S0C
And run stat --printf="%U %G" /tmp/hsperfdata_jboss/ in container and check its output for jboss root
Feature: Openshift OpenJDK S2I tests (Quarkus-based)

Scenario: Ensure Quarkus CDS doesn't fail due to timestamp mismatch (OPENDJK-1673)
Given s2i build https://github.com/jboss-container-images/openjdk-test-applications from getting-started
Expand Down
Loading