Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPENJDK-3038] echo out Tech Preview warning #527

Merged
merged 1 commit into from
Dec 4, 2024
Merged

[OPENJDK-3038] echo out Tech Preview warning #527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions modules/jlink/artifacts/opt/jboss/container/java/jlink/preflight.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,14 @@
jlink_techpreview_warning()
{
{
echo "WARNING WARNING WARNING"
echo " Jlink integration is a Tech Preview feature!"
echo " See <https://access.redhat.com/support/offerings/techpreview/>"
echo " for more information."
echo "WARNING WARNING WARNING"
} >&2
}

jlink_preflight_check()
{
# preflight check: do we have what we need?
Expand Down
8 changes: 4 additions & 4 deletions modules/jlink/tests/features/jlink.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
@ubi9/openjdk-17
@ubi9/openjdk-21
Feature: Openshift OpenJDK S2I tests (jlink specific)
Scenario: Ensure jlinked builder is used to build the containerized application image
Given s2i build https://github.com/jboss-container-images/openjdk-test-applications from quarkus-quickstarts/getting-started-3.0.1.Final-nos2i

Scenario: tech preview warning is printed (OPENJDK-3038)
Given failing s2i build https://github.com/jboss-container-images/openjdk-test-applications from spring-boot-sample-simple/target using master
| variable | value |
| S2I_ENABLE_JLINK | true |
| QUARKUS_PACKAGE_TYPE| uber-jar |
Then run ls /tmp/jre in container and check its output for bin
Then s2i build log should contain Jlink integration is a Tech Preview feature

Scenario: Ensure S2I_ENABLE_JLINK is not set to true
Given s2i build https://github.com/jboss-container-images/openjdk-test-applications from quarkus-quickstarts/getting-started-3.0.1.Final-nos2i
Expand Down
1 change: 1 addition & 0 deletions modules/s2i/bash/artifacts/usr/local/s2i/assemble
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ setup_java_app_and_lib
if [ "$S2I_ENABLE_JLINK" = "true" ]; then

source "${JBOSS_CONTAINER_JAVA_JLINK_MODULE}/preflight.sh"
jlink_techpreview_warning
jlink_preflight_check

source "${JBOSS_CONTAINER_JAVA_JLINK_MODULE}/mkdeps.sh"
Expand Down
Loading