feat: Allow reverse_lookup_filter to append new codes to existing comments #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksqsf
changed the title
2 tasks
eagleoflqj
added a commit
that referenced
this pull request
Sep 3, 2023
--------- Co-authored-by: Qijia Liu <[email protected]>
groverlynn
pushed a commit
to groverlynn/librime
that referenced
this pull request
Sep 27, 2023
Allow reverse_lookup_filter to append new codes to existing comments
groverlynn
pushed a commit
to groverlynn/librime
that referenced
this pull request
Sep 27, 2023
…e#701) --------- Co-authored-by: Qijia Liu <[email protected]>
graphemecluster
pushed a commit
to TypeDuck-HK/librime
that referenced
this pull request
Nov 2, 2023
Allow reverse_lookup_filter to append new codes to existing comments
graphemecluster
pushed a commit
to TypeDuck-HK/librime
that referenced
this pull request
Nov 2, 2023
…e#701) --------- Co-authored-by: Qijia Liu <[email protected]>
graphemecluster
pushed a commit
to TypeDuck-HK/librime
that referenced
this pull request
Nov 8, 2023
Allow reverse_lookup_filter to append new codes to existing comments
graphemecluster
pushed a commit
to TypeDuck-HK/librime
that referenced
this pull request
Nov 8, 2023
…e#701) --------- Co-authored-by: Qijia Liu <[email protected]>
2 tasks
Closed
graphemecluster
pushed a commit
to TypeDuck-HK/librime
that referenced
this pull request
Mar 18, 2024
Allow reverse_lookup_filter to append new codes to existing comments
graphemecluster
pushed a commit
to TypeDuck-HK/librime
that referenced
this pull request
Mar 18, 2024
…e#701) --------- Co-authored-by: Qijia Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Issue tracker
None
Feature
Allows
reverse_lookup_filterto append new information to existing comments, instead of just ignoring or overwriting them. Before this PR, the user has to discard some information when the comment and the new codes are not empty.This PR introduces a new option
append_comment, akin to the existingoverwrite_comment.append_commentistrue, the newly found codes are appended to the existing comments (separated with a space).append_commentandoverwrite_commentare true,overwrite_commenttakes priority, ie. the existing comments are discarded.Unit test
Not sure where to put the test? I'd be happy to add tests, should there be any guidance.
Manual test
Code Review
Additional Info