[DEPRECATED][BUGFIX] Move sleep to implement a 1s delay between pings for schema lock connection #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…his PR moves the sleep to the correct location at the end of the for loop.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
sergekh2
approved these changes
Dec 17, 2024
sergekh2
approved these changes
Dec 18, 2024
core/node/storage/pg_stream_store.go
Outdated
| return | ||
| } | ||
| } | ||
| // Wait 1s between db pings. |
There was a problem hiding this comment.
Comment is incorrect? But anyway it's redundant: it's pretty obvious from the code that this is sleep between pings.
There was a problem hiding this comment.
I'll take the comment out. In the meantime this PR is in a weird state because I'm trying to solicit more info about how the race condition bug is occurring and so it's regressing away from it's final state until I fix the issue causing the test flake.
clemire
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: This PR is built off of the schema lock feature, which has since been reverted. The replication bugs unearthed by this PR need to be fixed, then the schema lock reversion needs to be reverted again, and this can be applied on top of that PR.
The sleep was incorrectly placed previously, resulting in non-stop pings on the schema lock connection, which is unnecessary. This PR moves the sleep to the correct location so we ping once very second.