Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEPRECATED][BUGFIX] Move sleep to implement a 1s delay between pings for schema lock connection #1853

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

[DEPRECATED][BUGFIX] Move sleep to implement a 1s delay between pings for schema lock connection #1853

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
db30ff5
Sleep was incorrectly placed to implement a 1s delay between pings. T…
clemire Dec 17, 2024
c23f028
Reduce ping timer to 100ms.
clemire Dec 18, 2024
1426915
Test printing for TestReplAdd
clemire Dec 18, 2024
96be682
Enable debug logs for TestAddRepl.
clemire Dec 18, 2024
82d428e
enable only error logs.
clemire Dec 19, 2024
56f37f1
Re-institute 1s delay between pings. sleep with context proliferation…
clemire Dec 19, 2024
e1885e3
AddEvent log.
clemire Dec 19, 2024
3c39f57
Produce and apply mb logs.
clemire Dec 19, 2024
79d2eeb
Logging
clemire Dec 19, 2024
8154495
Start log for timestamp.
clemire Dec 19, 2024
658c0e4
Confirm initialized store
clemire Dec 19, 2024
32218ca
Log executeRemote call.
clemire Dec 19, 2024
9a5df10
Print on context cancellation
clemire Dec 19, 2024
0de0a76
Uncancel context to see if tests pass, hopefully no races.
clemire Dec 19, 2024
686a723
Print on the test that's breaking now.
clemire Dec 19, 2024
62d31ec
Debug messages
clemire Dec 20, 2024
47c8e26
Settings on localhost tls client. turn off logs.
clemire Dec 20, 2024
b9741f2
Node config to timeout dials locally to 100ms.
clemire Dec 20, 2024
1bf1360
Increase dial timeout. Remove extraneous error logs.
clemire Dec 20, 2024
3dd5144
Remove another log.
clemire Dec 20, 2024
77a0f4f
comment fix, etc.
clemire Dec 20, 2024
6b3a2d8
Set dial timeout to something unikely to break in CI.
clemire Dec 20, 2024
3bc054a
Polish uncancel before separating out to a separate PR.
clemire Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions core/node/storage/pg_stream_store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,10 +239,10 @@ func (s *PostgresStreamStore) maintainSchemaLock(
LogError(dlog.FromCtx(ctx))
s.exitSignal <- err
}

if err = SleepWithContext(ctx, 1*time.Second); err != nil {
return
}
}
// Wait 1s between db pings.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment is incorrect? But anyway it's redundant: it's pretty obvious from the code that this is sleep between pings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take the comment out. In the meantime this PR is in a weird state because I'm trying to solicit more info about how the race condition bug is occurring and so it's regressing away from it's final state until I fix the issue causing the test flake.

if err = SleepWithContext(ctx, 1*time.Second); err != nil {
return
}
}
}
Expand Down
Loading