Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[webcanvas] Improving usability with stressGraphics tests #17072

Merged
merged 12 commits into from
Nov 27, 2024
Merged

[webcanvas] Improving usability with stressGraphics tests #17072

merged 12 commits into from
Nov 27, 2024

Commits on Nov 26, 2024

  1. [webcanvas] proper support cont5 option for TGraph2D 

    This option is now handled by TGraph2D and does not
require histogram filling
Also P and P0 uses real TGraph2D drawing
    @linev
    linev committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    57ca5d6 View commit details
    Browse the repository at this point in the history

  2. [webcanvas] fix TGraph options handling 

    Check X+ or Y+ to create histogram
    @linev
    linev committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    06a6f2f View commit details
    Browse the repository at this point in the history

  3. [webcanv] improve TGraphPolar support 

    Let create TGraphPolargram when necessary
Provide access to polargram object
Avoid TFrame creation, create title
    @linev
    linev committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    17ed94d View commit details
    Browse the repository at this point in the history

  4. [webcanv] not always create stats box for TGraph 

    If gStyle->GetOptFit() returns 0, stats box for TGraph with TF1
will not be created
    @linev
    linev committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    d5d3f47 View commit details
    Browse the repository at this point in the history

  5. [webcanv] change canv_batch.htm file 

    Process several drawings sequentially to avoid concurency and high
memory consumption.
If done sequentially - there is no ambiguity which gStyle instance
has to be used.
Catch JSROOT exceptions (if any) - process at least images which
can be created and mark missing images as failures
    @linev
    linev committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    e8a7784 View commit details
    Browse the repository at this point in the history

  6. [webcanv] handle failures from canv_batch.htm 

    If failure happens during image production, report it
and try to create other images
    @linev
    linev committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    976ba41 View commit details
    Browse the repository at this point in the history

  7. [webcanv] do not warn when root or xml file should be created 

    If in web mode root or xml file is created do not print warning
    @linev
    linev committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    8ed53a3 View commit details
    Browse the repository at this point in the history

  8. [webgui] do not use gRandom in webdisplay classes 

    When required, instantiate TRandom3 instance directly.
Try to avoid interference with other tests relying on gRandom
    @linev
    linev committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    2715bfe View commit details
    Browse the repository at this point in the history

  9. Adjust stressGraphics.cxx code 

    Use better C++ syntax in the code
Replace "samecolorz" by "samecolz" option in waves() test
Set fixed time offset in tgaxis3() to get reproducible axis labels
    @linev
    linev committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    289ffd6 View commit details
    Browse the repository at this point in the history

  10. Implement build of reference files in stressGraphics.cxx 

    Let read several reference files generated by running
`stressGraphics -r`
And then find min/max for each test.
Define error as 1.5 of maximal deviation from mean value
To generate new reference file, call

./stressGraphics --build *.txt
    @linev
    linev committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    bf2c7a0 View commit details
    Browse the repository at this point in the history

  11. [jsroot] dev 26/11/2024 

    1. Implement cont5 draw option for `TGraph2D` using Delaunay algorithm
1. Adjust histogram title drawing with native implementation
1. Improve float to string convertion when 'g' is specified
1. Support "same" option for first histogram, draw direcly on pad
1. Support different angle coordiantes in `TGraphPolargram`
1. Fix - handle `TPave` NDC position also when fInit is not set
1. Fix - correctly position title according to gStyle->GetTitleAlign()
1. Fix - correctly handle tooltip events for `TGraphPolar`
1. Fix - align in #splitline

Many other small changes to make stressGraphics output
 very-very similar to original graphics
    @linev
    linev committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    b7d8ff7 View commit details
    Browse the repository at this point in the history

  12. Update stressGraphics_web.ref 

    Generated on base of tests on:
   - Linux chrome/firefox
   - MacOS chrome/firefox
   - Win64 chrome/firefox/edge

Produced with command:
```
./stressGraphics --web --build st*.txt > stressGraphics_web.ref
```
    @linev
    linev committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    782871d View commit details
    Browse the repository at this point in the history