-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
override head #60
override head #60
Conversation
Hmm yes it is unfortunate now we have to maintain this file separately from upstream pkgdown. It would be much nicer if we can opt-out in pkgdown itself. |
I think we can have this for now and simplify later if that becomes possible? |
Let's at least take out the GA part then, such that we don't end up with trackers on our domain. |
Can we look at the old head.html here: https://github.com/ropensci-org/rotemplate/blob/bs3-final/inst/pkgdown/templates/head.html I think we also need to port the favicon lines, because we use hardcoded ropensci favicons instead of ones provided by the package, e.g. https://docs.ropensci.org/apple-touch-icon.png and so on. Perhaps we should also be setting the twitter cards and so on in our template? |
I'll handle the opengraph stuff from our wrapper. |
actually the opengraph automatic stuff is already ok (from pkgdown itself) |
Thanks! |
Related to #55 (that I'd like to keep open depending on r-lib/pkgdown#1966)
The head.html is the same as pkgdown minus the MathJax lines.