Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

override head #60

Merged
merged 5 commits into from
Dec 13, 2021
Merged

override head #60

merged 5 commits into from
Dec 13, 2021

Conversation

maelle
Copy link
Contributor

@maelle maelle commented Dec 13, 2021

Related to #55 (that I'd like to keep open depending on r-lib/pkgdown#1966)

The head.html is the same as pkgdown minus the MathJax lines.

@maelle maelle requested a review from jeroen December 13, 2021 11:55
@jeroen
Copy link
Contributor

jeroen commented Dec 13, 2021

Hmm yes it is unfortunate now we have to maintain this file separately from upstream pkgdown. It would be much nicer if we can opt-out in pkgdown itself.

@maelle
Copy link
Contributor Author

maelle commented Dec 13, 2021

I think we can have this for now and simplify later if that becomes possible?

@jeroen
Copy link
Contributor

jeroen commented Dec 13, 2021

Let's at least take out the GA part then, such that we don't end up with trackers on our domain.

@jeroen
Copy link
Contributor

jeroen commented Dec 13, 2021

Can we look at the old head.html here: https://github.com/ropensci-org/rotemplate/blob/bs3-final/inst/pkgdown/templates/head.html

I think we also need to port the favicon lines, because we use hardcoded ropensci favicons instead of ones provided by the package, e.g. https://docs.ropensci.org/apple-touch-icon.png and so on.

Perhaps we should also be setting the twitter cards and so on in our template?

@maelle
Copy link
Contributor Author

maelle commented Dec 13, 2021

I'll handle the opengraph stuff from our wrapper.

@maelle
Copy link
Contributor Author

maelle commented Dec 13, 2021

actually the opengraph automatic stuff is already ok (from pkgdown itself)

@jeroen jeroen merged commit ea47b23 into master Dec 13, 2021
@jeroen jeroen deleted the mathjax branch December 13, 2021 15:13
@jeroen
Copy link
Contributor

jeroen commented Dec 13, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants