-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CM] Remove deprecated parameters for initial component states. #1357
[CM] Remove deprecated parameters for initial component states. #1357
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not thoroughly test this, but that compile issue is definitively there.
Co-authored-by: Felix Exner (fexner) <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1357 +/- ##
==========================================
+ Coverage 47.49% 47.58% +0.09%
==========================================
Files 41 41
Lines 3556 3545 -11
Branches 1938 1926 -12
==========================================
- Hits 1689 1687 -2
Misses 459 459
+ Partials 1408 1399 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that I could still successfully configure initial component state with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A part of #1237