Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CM] Remove deprecated parameters for initial component states. #1357

Merged
merged 6 commits into from
Feb 28, 2024

Conversation

destogl
Copy link
Member

@destogl destogl commented Feb 1, 2024

A part of #1237

Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not thoroughly test this, but that compile issue is definitively there.

controller_manager/src/controller_manager.cpp Show resolved Hide resolved
Co-authored-by: Felix Exner (fexner) <[email protected]>
@destogl destogl requested a review from fmauch February 2, 2024 16:53
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 47.58%. Comparing base (786d5b5) to head (39e7050).
Report is 19 commits behind head on master.

❗ Current head 39e7050 differs from pull request most recent head 3efb042. Consider uploading reports for the commit 3efb042 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1357      +/-   ##
==========================================
+ Coverage   47.49%   47.58%   +0.09%     
==========================================
  Files          41       41              
  Lines        3556     3545      -11     
  Branches     1938     1926      -12     
==========================================
- Hits         1689     1687       -2     
  Misses        459      459              
+ Partials     1408     1399       -9     
Flag Coverage Δ
unittests 47.58% <20.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
controller_manager/src/controller_manager.cpp 38.95% <20.00%> (+0.18%) ⬆️

Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that I could still successfully configure initial component state with this.

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@destogl destogl merged commit 69e5e27 into master Feb 28, 2024
11 checks passed
@destogl destogl deleted the cm-remove-deprecated-parameters-for-component-state branch February 28, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants