Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ControllerInterface] Avoid warning about conversion from int64_t to unsigned int (backport #1173) #1631

Merged
merged 2 commits into from
Jul 21, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 20, 2024

Without this there is a warning. For what I found the best way is to do static cast.

ros2_control/controller_interface/src/controller_interface_base.cpp:88:67: warning: conversion from ‘int64_t’{aka ‘long int’} to ‘unsigned int’ may change value [-Wconversion]
88 |     update_rate_ = get_node()->get_parameter("update_rate").as_int();

#GitHub-Programming-Rocks


This is an automatic backport of pull request #1173 done by Mergify.

…o `unsigned int` (#1173)

Without this there is a warning. For what I found the best way is to do static cast.

```
ros2_control/controller_interface/src/controller_interface_base.cpp:88:67: warning: conversion from ‘int64_t’{aka ‘long int’} to ‘unsigned int’ may change value [-Wconversion]
88 |     update_rate_ = get_node()->get_parameter("update_rate").as_int();
```

(cherry picked from commit 2569b76)

# Conflicts:
#	controller_interface/src/controller_interface_base.cpp
Copy link
Contributor Author

mergify bot commented Jul 20, 2024

Cherry-pick of 2569b76 has failed:

On branch mergify/bp/humble/pr-1173
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 2569b76.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   controller_interface/src/controller_interface_base.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Jul 20, 2024
Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.98%. Comparing base (a03055d) to head (1dd8351).
Report is 2 commits behind head on humble.

Additional details and impacted files
@@           Coverage Diff           @@
##           humble    #1631   +/-   ##
=======================================
  Coverage   86.98%   86.98%           
=======================================
  Files          97       97           
  Lines        7508     7508           
  Branches      677      677           
=======================================
  Hits         6531     6531           
  Misses        690      690           
  Partials      287      287           
Flag Coverage Δ
unittests 86.98% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...roller_interface/src/controller_interface_base.cpp 84.78% <100.00%> (ø)

@bmagyar bmagyar merged commit 4c0a160 into humble Jul 21, 2024
9 of 11 checks passed
@bmagyar bmagyar deleted the mergify/bp/humble/pr-1173 branch July 21, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants