-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constify the exported state interfaces using ConstSharedPtr #1767
Constify the exported state interfaces using ConstSharedPtr #1767
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1767 +/- ##
==========================================
- Coverage 86.92% 86.90% -0.03%
==========================================
Files 118 118
Lines 11436 11438 +2
Branches 1051 1051
==========================================
- Hits 9941 9940 -1
- Misses 1129 1131 +2
- Partials 366 367 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request is in conflict. Could you fix it @saikishor? |
c3a1924
to
811caea
Compare
0d7cf29
to
2205989
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks!
As discussed in #1688, this PR aims to export the ConstSharedPtr of the StateInterfaces from thew hardware components and internally within the ResourceManager