Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constify the exported state interfaces using ConstSharedPtr #1767

Conversation

saikishor
Copy link
Member

As discussed in #1688, this PR aims to export the ConstSharedPtr of the StateInterfaces from thew hardware components and internally within the ResourceManager

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.90%. Comparing base (1c7a5d1) to head (2205989).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ce/include/hardware_interface/system_interface.hpp 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1767      +/-   ##
==========================================
- Coverage   86.92%   86.90%   -0.03%     
==========================================
  Files         118      118              
  Lines       11436    11438       +2     
  Branches     1051     1051              
==========================================
- Hits         9941     9940       -1     
- Misses       1129     1131       +2     
- Partials      366      367       +1     
Flag Coverage Δ
unittests 86.90% <93.93%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...oller_interface/chainable_controller_interface.hpp 100.00% <ø> (ø)
...lude/controller_interface/controller_interface.hpp 100.00% <ø> (ø)
...controller_interface/controller_interface_base.hpp 90.00% <ø> (ø)
...r_interface/src/chainable_controller_interface.cpp 54.71% <100.00%> (+0.43%) ⬆️
controller_interface/src/controller_interface.cpp 75.00% <ø> (ø)
...rface/test/test_chainable_controller_interface.cpp 100.00% <100.00%> (ø)
controller_manager/src/controller_manager.cpp 76.83% <100.00%> (-0.25%) ⬇️
..._interface/include/hardware_interface/actuator.hpp 100.00% <ø> (ø)
.../include/hardware_interface/actuator_interface.hpp 94.11% <100.00%> (ø)
...re_interface/include/hardware_interface/handle.hpp 100.00% <ø> (ø)
... and 9 more

@saikishor saikishor changed the title Constify the exported state interfaces to ConstSharedPtr Constify the exported state interfaces using ConstSharedPtr Sep 26, 2024
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

mergify bot commented Oct 7, 2024

This pull request is in conflict. Could you fix it @saikishor?

@saikishor saikishor force-pushed the export/const_state_interface_shared_ptr branch from 0d7cf29 to 2205989 Compare October 7, 2024 20:41
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks!

@destogl destogl merged commit a6e44ab into ros-controls:master Oct 8, 2024
17 of 19 checks passed
@saikishor saikishor deleted the export/const_state_interface_shared_ptr branch October 8, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants