Fix spawner behaviour on failing controller activation or deactivation

[saikishor]

Before the fix proposed in this PR, the spawner reports the controller activation as successful, if the activation is failed at the last stage after calling activate_controllers. This PR addresses the issue by proposing a fix and this should now properly fail at the spawner end as well

Before the fix:

1: [INFO] [1734338012.820800005] [test_controller_manager]: Activating controllers: [ ctrl_with_joint1_and_joint2_command_interfaces ]
1: [ERROR] [1734338012.829138606] [test_controller_manager]: Resource conflict for controller 'ctrl_with_joint1_and_joint2_command_interfaces'. Command interface 'joint1/position' is already claimed.
1: [INFO] [1734338012.830469222] [spawner_ctrl_with_joint1_and_joint2_command_interfaces]: Configured and activated ctrl_with_joint1_and_joint2_command_interfaces

With the proposed fix:

1: [INFO] [1734338233.806072093] [test_controller_manager]: Activating controllers: [ ctrl_with_joint1_and_joint2_command_interfaces ]
1: [ERROR] [1734338233.814172942] [test_controller_manager]: Resource conflict for controller 'ctrl_with_joint1_and_joint2_command_interfaces'. Command interface 'joint1/position' is already claimed.
1: [ERROR] [1734338233.814291503] [test_controller_manager]: Could not activate controller : 'ctrl_with_joint1_and_joint2_command_interfaces'
1: [ERROR] [1734338233.817168509] [spawner_ctrl_with_joint1_and_joint2_command_interfaces]: Failed to activate controller : ctrl_with_joint1_and_joint2_command_interfaces

[codecov]

Codecov Report

Attention: Patch coverage is 80.35714% with 11 lines in your changes missing coverage. Please review.

Project coverage is 87.71%. Comparing base (7374c43) to head (7805687).

Files with missing lines	Patch %	Lines
controller_manager/src/controller_manager.cpp	63.15%	5 Missing and 2 partials ⚠️
...r_manager/test/test_controller/test_controller.cpp	75.00%	1 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1941      +/-   ##
==========================================
- Coverage   87.73%   87.71%   -0.02%     
==========================================
  Files         122      122              
  Lines       13010    13065      +55     
  Branches     1165     1171       +6     
==========================================
+ Hits        11414    11460      +46     
- Misses       1165     1169       +4     
- Partials      431      436       +5     

Flag	Coverage Δ
unittests	87.71% <80.35%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
controller_manager/controller_manager/spawner.py	75.38% <ø> (+2.30%)	⬆️
...ontroller_manager/test/test_release_interfaces.cpp	87.50% <ø> (ø)
controller_manager/test/test_spawner_unspawner.cpp	96.65% <100.00%> (+0.17%)	⬆️
...r_manager/test/test_controller/test_controller.cpp	90.47% <75.00%> (-5.27%)	⬇️
controller_manager/src/controller_manager.cpp	76.12% <63.15%> (-0.27%)	⬇️

[christophfroehlich]

LGTM (At least the test you've written makes totally sense.)