-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(steering-odometry): handle infinite turning radius properly #1285
Merged
bmagyar
merged 3 commits into
ros-controls:master
from
nobleo:fix/steering-odometry-infinite-turning-radius
Sep 11, 2024
Merged
fix(steering-odometry): handle infinite turning radius properly #1285
bmagyar
merged 3 commits into
ros-controls:master
from
nobleo:fix/steering-odometry-infinite-turning-radius
Sep 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
arne48,
bmagyar,
DasRoteSkelett,
destogl,
fmauch,
moriarty and
saikishor
September 10, 2024 14:40
saikishor
requested changes
Sep 10, 2024
Co-authored-by: Sai Kishor Kothakota <[email protected]>
Co-authored-by: Sai Kishor Kothakota <[email protected]>
bmagyar
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1285 +/- ##
==========================================
- Coverage 80.36% 80.34% -0.02%
==========================================
Files 105 105
Lines 9389 9394 +5
Branches 827 831 +4
==========================================
+ Hits 7545 7548 +3
Misses 1571 1571
- Partials 273 275 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bmagyar
added
backport-humble
This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
backport-iron
labels
Sep 11, 2024
mergify bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
(cherry picked from commit 1dc3d2a)
mergify bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
(cherry picked from commit 1dc3d2a)
christophfroehlich
pushed a commit
that referenced
this pull request
Sep 12, 2024
(cherry picked from commit 1dc3d2a)
christophfroehlich
pushed a commit
that referenced
this pull request
Sep 12, 2024
(cherry picked from commit 1dc3d2a)
christophfroehlich
pushed a commit
that referenced
this pull request
Sep 12, 2024
… (#1287) (cherry picked from commit 1dc3d2a) Co-authored-by: Rein Appeldoorn <[email protected]>
christophfroehlich
pushed a commit
that referenced
this pull request
Sep 12, 2024
… (#1286) (cherry picked from commit 1dc3d2a) Co-authored-by: Rein Appeldoorn <[email protected]>
RobertWilbrandt
pushed a commit
to RobertWilbrandt/ros2_controllers
that referenced
this pull request
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-humble
This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.