Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing deps for test_nodes #1378

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Add missing deps for test_nodes #1378

merged 2 commits into from
Nov 22, 2024

Conversation

christophfroehlich
Copy link
Contributor

Closes #1377

2024-11-20T04:17:11.0314151Z     from launch_ros.substitutions import FindPackageShare
2024-11-20T04:17:11.0315851Z E   ModuleNotFoundError: No module named 'launch_ros'
2024-11-20T04:17:11.0318975Z - generated xml file: /__w/ros2_controllers/ros2_controllers/ros_ws/build/ros2_controllers_test_nodes/pytest.xml -

@christophfroehlich christophfroehlich added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. label Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.57%. Comparing base (79358e3) to head (608c25b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1378      +/-   ##
==========================================
- Coverage   83.57%   83.57%   -0.01%     
==========================================
  Files         122      122              
  Lines       10960    10959       -1     
  Branches      929      928       -1     
==========================================
- Hits         9160     9159       -1     
- Misses       1489     1490       +1     
+ Partials      311      310       -1     
Flag Coverage Δ
unittests 83.57% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...st_publisher_forward_position_controller_launch.py 100.00% <100.00%> (ø)
...st_publisher_joint_trajectory_controller_launch.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

---- 🚨 Try these New Features:

@bmagyar bmagyar merged commit a5bb11b into master Nov 22, 2024
17 of 19 checks passed
@bmagyar bmagyar deleted the fix/deps branch November 22, 2024 10:15
mergify bot pushed a commit that referenced this pull request Nov 22, 2024
christophfroehlich added a commit that referenced this pull request Nov 22, 2024
(cherry picked from commit a5bb11b)

Co-authored-by: Christoph Fröhlich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI build job rolling/source failed!
4 participants