Add missing controllers and broadcasters to ros2_controllers dependencies #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
anfemosa,
ARK3r,
bijoua29,
bmagyar,
christophfroehlich,
DasRoteSkelett and
harderthan
saikishor
commented
Dec 9, 2024
due to CI configuration
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1413 +/- ##
==========================================
- Coverage 83.64% 83.63% -0.01%
==========================================
Files 122 122
Lines 10985 10986 +1
Branches 932 933 +1
==========================================
Hits 9188 9188
Misses 1488 1488
- Partials 309 310 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Humble needs a different patch, we don't have the parallel gripper controller there. |
Sure. I can create a backport manually. |
saikishor
added a commit
that referenced
this pull request
Dec 9, 2024
christophfroehlich
pushed a commit
that referenced
this pull request
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing dependencies of new controllers and broadcasters in ros2_controllers package