-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FTS Broadcaster] Add support for publishing forces in other frames on additional topics #268
base: master
Are you sure you want to change the base?
Conversation
2eb951d
to
f893c57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but please please add 2 new tests:
- checking the wrench
- checking additional frames
This pull request is in conflict. Could you fix it @destogl? |
1 similar comment
This pull request is in conflict. Could you fix it @destogl? |
This pull request is in conflict. Could you fix it @destogl? |
@destogl are you ready to move this ahead? |
This pull request is in conflict. Could you fix it @destogl? |
This has to be cleaned a bit to split “additional topics” and filtering functionalities into separate PRs.
I would be glad to get some help with tests.
Documentation on new parameter is also missing.