Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FTS Broadcaster] Add support for publishing forces in other frames on additional topics #268

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

destogl
Copy link
Member

@destogl destogl commented Nov 16, 2021

This has to be cleaned a bit to split “additional topics” and filtering functionalities into separate PRs.

I would be glad to get some help with tests.

Documentation on new parameter is also missing.

@destogl destogl force-pushed the extend-fts-broadcaster branch from 2eb951d to f893c57 Compare November 17, 2021 20:11
@destogl destogl marked this pull request as ready for review November 17, 2021 20:14
@bmagyar bmagyar self-requested a review November 19, 2021 00:49
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but please please add 2 new tests:

  • checking the wrench
  • checking additional frames

@destogl destogl changed the title Add support for publishing additional topics to the FTS Broadcaster [FTS Broadcaster] Add support for publishing forces in other frames on additional topics Mar 1, 2022
@mergify
Copy link
Contributor

mergify bot commented May 3, 2022

This pull request is in conflict. Could you fix it @destogl?

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2022

This pull request is in conflict. Could you fix it @destogl?

@mergify
Copy link
Contributor

mergify bot commented Mar 28, 2023

This pull request is in conflict. Could you fix it @destogl?

@bmagyar
Copy link
Member

bmagyar commented May 16, 2023

@destogl are you ready to move this ahead?

gwalck pushed a commit to StoglRobotics-forks/ros2_controllers that referenced this pull request Jun 7, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 15, 2023

This pull request is in conflict. Could you fix it @destogl?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants