Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve jtc docs regarding the combination of joints and interfaces #980

Closed
wants to merge 6 commits into from

Conversation

fmauch
Copy link
Contributor

@fmauch fmauch commented Jan 17, 2024

This basically implements #979 and builds upon #652, since the description has been moved to the parameters file. Making this a draft until #652 is merged.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6623cdd) 47.81% compared to head (cceaa03) 47.61%.
Report is 3 commits behind head on master.

❗ Current head cceaa03 differs from pull request most recent head d536397. Consider uploading reports for the commit d536397 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #980      +/-   ##
==========================================
- Coverage   47.81%   47.61%   -0.21%     
==========================================
  Files          41       41              
  Lines        3871     3871              
  Branches     1827     1827              
==========================================
- Hits         1851     1843       -8     
- Misses        751      760       +9     
+ Partials     1269     1268       -1     
Flag Coverage Δ
unittests 47.61% <ø> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@christophfroehlich
Copy link
Contributor

@fmauch you probably could make a PR against the branch in my fork, then we can merge your changes together with the rest?

@fmauch
Copy link
Contributor Author

fmauch commented Jan 21, 2024

Sure thing.

@fmauch
Copy link
Contributor Author

fmauch commented Jan 21, 2024

Closing this in favor of christophfroehlich#4

@fmauch fmauch closed this Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants