Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[JTC] Remove read_only from 'joints', 'state_interfaces' and 'command_interfaces' parameters (#967)" (backport #978) #986

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 25, 2024

This is an automatic backport of pull request #978 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

…'command_interfaces' parameters (#967)" (#978)

This reverts commit 6e2736b.

(cherry picked from commit 9f7e9e9)
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (73282d9) 47.25% compared to head (5236c6f) 46.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##           humble     #986      +/-   ##
==========================================
- Coverage   47.25%   46.82%   -0.43%     
==========================================
  Files          40       40              
  Lines        3722     3722              
  Branches     1780     1786       +6     
==========================================
- Hits         1759     1743      -16     
- Misses        723      738      +15     
- Partials     1240     1241       +1     
Flag Coverage Δ
unittests 46.82% <ø> (-0.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@destogl destogl merged commit 5dea782 into humble Jan 26, 2024
14 of 15 checks passed
@destogl destogl deleted the mergify/bp/humble/pr-978 branch January 26, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants