Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve runtime error due to fails in loading ESmodules #25

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Conversation

Rindrics
Copy link
Collaborator

@Rindrics Rindrics commented Jun 18, 2024

this PR closes #8 by importing dayjs plugins as ESmodules to resolve runtime error

the error was:

@Rindrics Rindrics marked this pull request as ready for review June 18, 2024 09:06
@Rindrics Rindrics added the bug Something isn't working label Jun 18, 2024
@Rindrics Rindrics changed the title Reproduce runtime error Resolve runtime error due to fails in loading ESmodules Jun 18, 2024
@Rindrics Rindrics requested review from bvlion and rz1nk June 18, 2024 09:48
@Rindrics Rindrics self-assigned this Jun 18, 2024
Copy link

@bvlion bvlion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! thx👍

@Rindrics
Copy link
Collaborator Author

thx!

@Rindrics Rindrics merged commit c9a9cbe into main Jun 19, 2024
1 check passed
@Rindrics Rindrics deleted the fix-issue-08 branch June 19, 2024 03:53
@github-actions github-actions bot mentioned this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify cost aggregation logic
2 participants