Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve runtime error due to fails in loading ESmodules #25

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Resolve runtime error due to fails in loading ESmodules #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3517c0f
Reproduce runtime error
Rindrics Jun 17, 2024
aae0c9d
Import `dayjs` plugins as ESmodule to resolve runtime error
Rindrics Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,14 @@ jobs:
node-version-file: '.node-version'
cache: 'pnpm'

- name: Install dependencies
run: make install
- name: Install dependencies & build application
run: make

- name: Lint & format
run: make lint

- name: Run tests
run: make test

- name: Confirm no error
run: make version
3 changes: 3 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,6 @@ lint:

format:
pnpm format

version:
pnpm exec node $(BUILD_DIR)/index.js --version
4 changes: 2 additions & 2 deletions src/cost.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import AWS from 'aws-sdk';
import dayjs from 'dayjs';
import isSameOrAfter from 'dayjs/plugin/isSameOrAfter';
import isSameOrBefore from 'dayjs/plugin/isSameOrBefore';
import isSameOrAfter from 'dayjs/plugin/isSameOrAfter.js';
import isSameOrBefore from 'dayjs/plugin/isSameOrBefore.js';
dayjs.extend(isSameOrAfter);
dayjs.extend(isSameOrBefore);
import { AWSConfig } from './config';
Expand Down