Sanitize signing operation output #3424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmnks
approved these changes
Nov 6, 2024
In the fakechroot days there was just no way to get gpg to run inside that contraption, with the "new" container stuff, we can just run everything there. Makes life simpler in many ways. GPG still needs GPG_TTY set, do this centrally from snapshot() to get it out of all the individual tests.
--addsign and --delsign used to emit output like below, which makes you expect some additional output, where there will be none: /some/path.rpm: Make sure all the error messages give a path you can relate to, only emit the file name in INFO level in case of success. No news is good news, right? So on success you now only get the following IFF operation succeeds and -v was specified: /some/path.rpm This also means we don't need to filter out these meaningless messages all over the place in the test-suite, remove now unndecessary /dev/null redirects and add -v to one case of both --addsign and --delsign to cover that case.
|
Hmm, I found one leftover /dev/null redirect in my local tree but not the one you mentioned, I wonder if this is GH playing tricks... anyway, fixed the one I found 😅 |
Yeah, I realized I had commented on an outdated commit so deleted the comment right away 😅 Juggling too many branches/PRs, indeed... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only output filenames on addsign/delsign success on verbose mode, no news is good news. Previusly we emitted non-sensical messages like this:
/some/path/my-1.rpm:
/some/path/my-2.rpm:
...presumably in anticipation of error messages, but it's saner to have error messages carry the path where relevant.
Loosely related to the multiple signatures stuff - this was driving me crazy when writing tests.