Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize signing operation output #3424

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Sanitize signing operation output #3424

merged 2 commits into from
Nov 6, 2024

Commits on Nov 6, 2024

  1. Run all signing tests with runroot since we now can 

    In the fakechroot days there was just no way to get gpg to run
inside that contraption, with the "new" container stuff, we can just
run everything there. Makes life simpler in many ways.

GPG still needs GPG_TTY set, do this centrally from snapshot()
to get it out of all the individual tests.
    @pmatilai
    pmatilai committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    be71697 View commit details
    Browse the repository at this point in the history

  2. Sanitize rpmsign --addsign/--delsign output 

    --addsign and --delsign used to emit output like below, which makes
you expect some additional output, where there will be none:

	/some/path.rpm:

Make sure all the error messages give a path you can relate to,
only emit the file name in INFO level in case of success.
No news is good news, right? So on success you now only get the
following IFF operation succeeds and -v was specified:

	/some/path.rpm

This also means we don't need to filter out these meaningless messages
all over the place in the test-suite, remove now unndecessary /dev/null
redirects and add -v to one case of both --addsign and --delsign to
cover that case.
    @pmatilai
    pmatilai committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    9d6dd46 View commit details
    Browse the repository at this point in the history