fix(navbar): Validate gap and padding early (#991)

NEWS.md

@@ -34,6 +34,8 @@
 
 * `uiOutput()` no longer yields unwanted double padding when it's parent container uses `gap` for spacing multiple elements (e.g., `layout_columns()`, `page_fillable()`, etc). (#992)
 
+* `page_navbar()` and `navset_bar()` now validate and transform `padding` and `gap` arguments into appropriate CSS values. (#991)
+
 # bslib 0.6.1
 
 ## Bug fixes

R/navs-legacy.R

@@ -112,6 +112,9 @@ navset_bar <- function(..., title = NULL, id = NULL, selected = NULL,
                      header = NULL, footer = NULL,
                      bg = NULL, inverse = "auto",
                      collapsible = TRUE, fluid = TRUE) {
+  padding <- validateCssPadding(padding)
+  gap <- validateCssUnit(gap)
+
   navs_bar_(
     ..., title = title, id = id, selected = selected,
     sidebar = sidebar, fillable = fillable,

R/page.R

@@ -190,6 +190,7 @@ page_fillable <- function(
 }
 
 validateCssPadding <- function(padding = NULL) {
+  if (is.null(padding)) return(NULL)
   paste(
     vapply(padding, validateCssUnit, character(1)),
     collapse = " "
@@ -386,6 +387,9 @@ page_navbar <- function(
 
   sidebar <- maybe_page_sidebar(sidebar)
 
+  padding <- validateCssPadding(padding)
+  gap <- validateCssUnit(gap)
+
   # Default to fillable = F when this is called from shiny::navbarPage()
   # TODO: update shiny::navbarPage() to set fillable = FALSE and get rid of this hack
   if (missing(fillable)) {