add semicolons to appease a brittle parser #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
reviewed
Aug 26, 2024
NEWS.md
Outdated
| @@ -1,6 +1,7 @@ | |||
| # bslib (development version) | |||
|
|
|||
| * `navset_card_pills()`, `navset_card_underline()`, `navset_card_tabs()` fixed to now respect header/footer arguments (@tanho63, #1024) | |||
| * added terminating semicolons to declarations in `value_box.scss` and `sidebar.scss` to prevent issues with parsers that require them. (@cscheid, #1104) | |||
There was a problem hiding this comment.
Suggested change
| * added terminating semicolons to declarations in `value_box.scss` and `sidebar.scss` to prevent issues with parsers that require them. (@cscheid, #1104) | |
| * Added terminating semicolons to declarations in `value_box.scss` and `sidebar.scss` to prevent issues with parsers that require them. (@cscheid, #1104) |
There was a problem hiding this comment.
No offense @cscheid but I don't think this is a newsworthy change 😄
There was a problem hiding this comment.
I didn't know your criteria, my bad!
cpsievert
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Thanks! Seems ok to me, but I'll let @gadenbuie decide before merging
gadenbuie
approved these changes
Aug 26, 2024
gadenbuie
reviewed
Aug 26, 2024
Co-authored-by: Garrick Aden-Buie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1104.
Pull Request
Before you submit a pull request, please ensure you've completed the following che.klist
Ensure there is an already open and relevant GitHub issue describing the problem in detail and you've already received some indication from the maintainers that they are welcome to a contribution to fix the problem. This helps us to prevent wasting anyone's time.
This project uses roxygen2 for documentation. If you've made changes to documentation, run
devtools::document().Run
devtools::check()(or, equivalently, click on Build->Check Package in the RStudio IDE) to make sure your change did not add any messages, warnings, or errors.Ensure your code changes follow the style outlined in http://r-pkgs.had.co.nz/style.html
Add an entry to NEWS.md concisely describing what you changed.
I haven't done that, because I'm not sure how you're testing SCSS syntax here. Happy to do so if someone points me in the right direction.