Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add semicolons to appease a brittle parser #1105

Merged
merged 3 commits into from
Aug 26, 2024
Merged

add semicolons to appease a brittle parser #1105

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db6439d
add semicolons to appease a brittle parser
cscheid Aug 24, 2024
867c3e8
NEWS.md entry
cscheid Aug 24, 2024
5a370e2
Update NEWS.md
cpsievert Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# bslib (development version)

* `navset_card_pills()`, `navset_card_underline()`, `navset_card_tabs()` fixed to now respect header/footer arguments (@tanho63, #1024)
* added terminating semicolons to declarations in `value_box.scss` and `sidebar.scss` to prevent issues with parsers that require them. (@cscheid, #1104)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* added terminating semicolons to declarations in `value_box.scss` and `sidebar.scss` to prevent issues with parsers that require them. (@cscheid, #1104)
* Added terminating semicolons to declarations in `value_box.scss` and `sidebar.scss` to prevent issues with parsers that require them. (@cscheid, #1104)

Copy link
Member

@gadenbuie gadenbuie Aug 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No offense @cscheid but I don't think this is a newsworthy change 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know your criteria, my bad!

cpsievert marked this conversation as resolved.
Show resolved Hide resolved

# bslib 0.8.0

Expand Down
2 changes: 1 addition & 1 deletion inst/components/scss/sidebar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ $bslib-sidebar-column-sidebar: Min(calc(100% - var(--_padding-icon)), var(--_sid
.bslib-sidebar-layout {
&, &.sidebar-right {
// Remove sidebar borders in mobile view (except always-open, added below)
> .sidebar { border: none }
> .sidebar { border: none; }

// Main area takes up entire layout area to avoid layout shift when
// sidebar is expanded as an overlay.
Expand Down
4 changes: 2 additions & 2 deletions inst/components/scss/value_box.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,15 +85,15 @@ $bslib-value-box-horizontal-break-point: 300px !default;
@include bootstrap-heading-font-and-spacing($h6-font-size);
// add a non-breaking space to ensure it's not 0 height
&:empty::after {
content: '\00a0 '
content: '\00a0 ';
}
}

.value-box-value {
@include bootstrap-heading-font-and-spacing($h2-font-size);
// add a non-breaking space to ensure it's not 0 height
&:empty::after {
content: '\00a0 '
content: '\00a0 ';
}
}

Expand Down
Loading