Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: resolve bugsnag issue in braze #3474

Merged
merged 6 commits into from
Jun 26, 2024
Merged

Conversation

sandeepdsvs
Copy link
Contributor

What are the changes introduced in this PR?

Resolved bugsnag issue for Braze destination

What is the related Linear task?

Resolves INT-2297

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@sandeepdsvs sandeepdsvs requested a review from a team as a code owner June 18, 2024 07:22
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.07%. Comparing base (3f9bfac) to head (512243a).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3474      +/-   ##
===========================================
+ Coverage    88.06%   88.07%   +0.01%     
===========================================
  Files          577      579       +2     
  Lines        31207    31239      +32     
  Branches      7442     7442              
===========================================
+ Hits         27483    27515      +32     
- Misses        3386     3414      +28     
+ Partials       338      310      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sandeepdsvs sandeepdsvs requested review from sivashanmukh and a team as code owners June 24, 2024 12:41
utsabc
utsabc previously approved these changes Jun 24, 2024
anantjain45823
anantjain45823 previously approved these changes Jun 24, 2024
Copy link

sonarcloud bot commented Jun 25, 2024

@sandeepdsvs sandeepdsvs merged commit dc83798 into develop Jun 26, 2024
17 checks passed
@sandeepdsvs sandeepdsvs deleted the chore.bugsbag-braze branch June 26, 2024 04:44
@kanishkkatara kanishkkatara restored the chore.bugsbag-braze branch June 26, 2024 09:48
@devops-github-rudderstack devops-github-rudderstack deleted the chore.bugsbag-braze branch September 26, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants